Android: Theme change

[Valdnet]

Steps to reproduce

1. Select app settings.
2. Change the theme to "Dark".
3. Change the theme to "Follow system" again.
4. Exit settings.
5. The theme is still dark "Dark".

The theme changes only after restarting the app.

Expected behaviour

• Correct display of the theme after changing it.

Actual behaviour

• Incorrect theme change.

Environment data

Android version: 10

Nextcloud app version: 3.11.1

Nextcloud server version: 18.0.3

[tobiasKaminsky]

@dan0xii @AndyScherzinger can you both maybe look into it, and try to reproduce and then fix it? :heart:

[AndyScherzinger]

Maybe @dan0xii has an idea

[dan0xii]

Think so. Will have a PR later on today.

[AndyScherzinger]

Fixed via #5952

[AndyScherzinger]

Thanks @dan0xii ❤️

[tobiasKaminsky]

I think the first approach to fix this did not worked out, so I re-open it.

[tobiasKaminsky]

let me give it a try

[tobiasKaminsky]

• Select app settings.

• Change the theme to "Dark".

• Change the theme to "Follow system" again.

• Exit settings.

• The theme is still dark "Dark".

I tried this with latest master and it works as expected for me…
Can you try latest dev version?

[tobiasKaminsky]

@dan0xii

According to my my understanding setLocalNight(…) and applyDayNight() is only needed if we want to override the default folllow system.

[Valdnet]

Can you try latest dev version?

@tobiasKaminsky It's the same with the dev 20200429 version.

[stale[bot]]

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[Shagequi]

UP ! @dan0xii