Android: Drawer is swipeable from the left on image/picture preview

[Shagequi]

Hi,

The Drawer is swipeable from the left when we consult a picture. Given the full screen mode, the Drawer is cropped and not really useful.

Is it needed ?

App version : 3.9.0

[AndyScherzinger]

Nope, not needed. The issue here (just a guess, haven't looked at the code) is that the activity inherits the DrawerActivity which might well be because of the Tablet behavior (where this would just be on the left (file list, etc.) Not sure though.

cc @tobiasKaminsky

[Shagequi]

Normally, this block :

        mFullScreenAnchorView.setOnSystemUiVisibilityChangeListener
                (flags -> {
                    boolean visible = (flags & View.SYSTEM_UI_FLAG_HIDE_NAVIGATION) == 0;
                    if (visible) {
                        actionBar.show();
                        setDrawerLockMode(DrawerLayout.LOCK_MODE_UNLOCKED);
                    } else {
                        actionBar.hide();
                        setDrawerLockMode(DrawerLayout.LOCK_MODE_LOCKED_CLOSED);
                    }
                });

com/owncloud/android/ui/preview/PreviewImageActivity.java:121

shouldn't allow the Drawer in "visible mode". So we may remove this block and replace by only setDrawerLockMode(DrawerLayout.LOCK_MODE_LOCKED_CLOSED); to disallow Drawer swiping.

[AndyScherzinger]

Worth a try I guess 👍

[Shagequi]

Hi @AndyScherzinger :)

My fix works for pictures, but videos are concerned too (the Drawer is swipeable).
Do I need to fix for just pictures or videos too ?

[tobiasKaminsky]

Video is in PreviewVideoActivity.

[AndyScherzinger]

plus there is also the text preview activity

[stale[bot]]

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[Shagequi]

up

[Shagequi]

Can't understand why... the videos preview activity can't lock the Drawer.

[mario]

@Shagequi are you sure you are actually loading the Videos Preview activity? I really don't think that's used anymore, what you see when you click on a video is PreviewMediaFragment. See line 2343 in FileDisplayActivity in your branch. :) So you might want to handle the drawer locking/unlocking in the fragment lifecycle methods.

[Shagequi]

I'll work today on a fix for video preview activity/fragment (in order to hide the Drawer) @AndyScherzinger

[Shagequi]

Issue created