Android: The "Shared" item in Drawer (Shared Search Event) doesn't work ?

[Shagequi]

Hi,

The Shared Search Event (accessible from Drawer) doesn't seem to work on a complete NextCloud package

App : NextCloud 3.9.0
Server : NextCloud 17.0.1 - 17.0.1.1

The error returned on server is :

Error | PHP | Undefined offset: 0 at [...]/drive/3rdparty/icewind/searchdav/src/XML/Operator.php#71 |  

(I didn't change server configuration, and used default files provided with NextCloud)

Could you try to reproduce ?

[AndyScherzinger]

@tobiasKaminsky can you have a look at this? :)

[stale[bot]]

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[szaimen]

It isn't stale!

[stale[bot]]

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[Shagequi]

up

[tobiasKaminsky]

@icewind1991 do you have an idea what the problem might be?

[icewind1991]

what is the search request being sent?

[Shagequi]

@icewind1991 It's visibly not due to the server, the app doesn't seem to send data back to the server (because the search type is no longer handled/routed), we're investigating with @tobiasKaminsky

[Shagequi]

Due to unlink of SHARED_SEARCH in android-library

[tobiasKaminsky]

Plan is to have all types shown in "shared" view:

• incoming shares (other users shared with me)
• outgoing shares (I shared files/folders with other users)
• shared via link
• remote shares

http://localhost/nc/ocs/v1.php/apps/files_sharing/api/v1/shares?format=json&shared_with_me=false&include_tags=true
http://localhost/nc/ocs/v1.php/apps/files_sharing/api/v1/remote_shares?format=json&include_tags=true
http://localhost/nc/ocs/v1.php/apps/files_sharing/api/v1/shares?format=json&shared_with_me=true&include_tags=true

I will combine this in library so that the result is a big list of shares, which then can be shown in Files app.

[Shagequi]

@tobiasKaminsky Will the Activity contains removed shares like in web app (with a specific symbol/styling) ?

[tobiasKaminsky]

@Shagequi this is still to be discussed.
As of NC18, a quick win was to show it in side bar.
But goal is to have it on top of file list, so that user can immediately react on this.
There will be a general issue on how to do this, which also targets mobile integration.
I will then link it here.

[Shagequi]

@tobiasKaminsky Which point has to be discussed ?
The presence of "removed shares" ? Or all the shares and the way to display them to the user in Android app ?

[tobiasKaminsky]

Ah, I was talking about "pending shares".

Removed shares should be shown in the regular "share" list, but with a restore button.

[Shagequi]

Okay perfect :D
And do you have some news about the library issue ?

[tobiasKaminsky]

Planned for this week, hopefully.

[tobiasKaminsky]

Regarding "pending shares": https://github.com/nextcloud/server/issues/2192

[tobiasKaminsky]

So, plan is, according to @jancborchardt and me ;-) :
In "shared" pane:

• "Pending": sort by incoming date, most recent first
• "Shares": (all share, "my" shares, shares to me, shares via link, via mail, etc) sort by last modified, most recent first
• "Deleted": sorted by deletion date, most recent first

--> I will create for each three of them an RemoteOperation in lib.

[tobiasKaminsky]

As a quick win #5300, this will re-enable the old/current state, and shows only "shares".