Android: No edit on shared links on files

Created on 18 Apr 2019  路  5Comments  路  Source: nextcloud/android

2019-04-18-080018 2019-04-18-080003

On left (file) edit icon is missing.
This is due to:
https://github.com/nextcloud/android/blob/dc7a2c0e7e01a22b10407368e46a8eda43750148/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java#L247-L259

@AndyScherzinger as you changed it (no blame :-)), do you remember why you did this?

approved bug pr exists

All 5 comments

Now I know why.
When enabling via android, I do get "public upload is only possible for public shared folders".

Erm, I think I did this because I thought that there is no edit option on files shared by link.

At least on NC16 in web ui there is.
I'll figure this out and fix it :-)

Thanks a lot 馃槉馃憤

Sooner or later we have to do this

  • reflect all settings / layout like web ui
  • allow multiple share links
  • clean up
  • add test cases
Was this page helpful?
0 / 5 - 0 ratings

Related issues

eppfel picture eppfel  路  3Comments

Shagequi picture Shagequi  路  3Comments

tobiasKaminsky picture tobiasKaminsky  路  3Comments

tobiasKaminsky picture tobiasKaminsky  路  3Comments

ikke-t picture ikke-t  路  3Comments