Android: Username with blanks incomplete in drawer

Created on 19 Nov 2018  路  7Comments  路  Source: owncloud/android

Steps

  1. Create an account which username contain blanks
  2. Add the account and another one (no matter how the username is) to the app
  3. Open the second account
  4. Open the drawer and tap on the triangle

Current: account name created in 1. appears trimmed
Expected: account name created in 1. appears correctly in format user@server

Nexus 5X v8

PR

https://github.com/owncloud/android/pull/2465

Estimation - 2 (S) UI bug

All 7 comments

@jesmrec I would like to work on this.

I was unable to reproduce this issue for version 2.9.3.
I already had an account with a username without spaces. Added another one with spaces. Removed the first one and added it again.
The username for the one with spaces appears as

@abelgardep is currently working on it. Could you reproduce?

Yes, i was able to reproduce it.
I created an account with this username: 'a 1 b 2 c 3' (without the quotes).
In drawer, this username appears as 'a 1 b 2 c' but it should appear as 'a 1 b 2 c 3@server'
I have not found a fix yet.

@jesmrec @abelgardep Able to reproduce now. Any username with more than one space will be trimmed.

@svvashishtha we are not able to see where the problem comes from, you might want to have a look at it as well, thanks!

@davigonz I was able to find the root of the problem. Textview clips the text set to it when text is too large to fit in the given width.
If there's only one space in the username, the username is clipped at "@" or "/" etc. But if there are more than 1 spaces in the username, the username is clipped at the position of last space.
Example
"s [email protected]/owncloud" will be shown as "s [email protected]"
but
"s v [email protected]/owncloud" will be shown as "s v".

To confirm this, you can replace spaces with any other character at this line (https://github.com/owncloud/android/blob/master/owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java#L419) and the username will be displayed normally. (except the space replaced by other character thingy)

Was this page helpful?
0 / 5 - 0 ratings