Android: Issue with tabs and bookmarks

[ashucg]

App version
5.12.0
Device make and model
Micromax/Yuphoria - YU5010A
Android version
5.1.1
Steps to reproduce the bug
See the screencast (GIF)

Expected behavior
Should be able to use tabs and add bookmarks
Actual behavior
I am unable to add bookmarks or use tabs. You can see the attached screenshot, Add Bookmark is greyed out and if I try to open a new tab it just open it within the current view. Also if I close the app and re-open it, I lose the page I had opened before.
I've tried reinstalling the app but it still doesn't work properly.

[CDRussell]

Thank you so much for raising this issue. We've had a few people mention similar type problems with the latest release, but it wasn't clear exactly what they were describing or when it was happening from their reports.

This, however, is fantastic. This will definitely help identify the problem. In fact, I have a pretty good suspicion on where to look already.

My problem so far was that I was unable to replicate the problem. If I can continue to have this problem, would you (or anyone else looking at this ticket) be in a position to test a fix?

[ashucg]

Sure, I don't mind testing :)

[CDRussell]

Excellent; much appreciated.

Can you tell me which version of Chrome you have installed, and if it is
enabled?

On Sat, 27 Oct 2018, 08:09 Ashutosh Sharma, [e-mail]
wrote:

Sure, I don't mind testing :)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/duckduckgo/Android/issues/386#issuecomment-433597590,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRj2QEE6C6Jod_XbC8nnJ8dyl6F4IxWks5upAaSgaJpZM4X9SMu
.

[ashucg]

No, I don't have Chrome installed on my device

[CDRussell]

Ah, excellent. That's probably why I couldn't replicate. Can you find out
the version of WebView you have installed by any chance?

On Sat, 27 Oct 2018, 08:20 Ashutosh Sharma, [e-mail]
wrote:

No, I don't have Chrome installed on my device

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/duckduckgo/Android/issues/386#issuecomment-433598157,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABRj2U-3hLuMYN5Op6RUMJDO33WAhIjwks5upAktgaJpZM4X9SMu
.

[ashucg]

WebView (Beta) version: 71.0.3578.20

[CDRussell]

Thanks so much for all this info. Hopefully I'll be able to replicate this now.

I'll post back when I have more info, or if I need help testing a fix (hopefully won't be needed).

Current line of thinking is that the problem might be because we moved the timing of when the current URL property was set to a different WebView callback.

Will update later when I have an update. Thanks again for all this info.

[CDRussell]

Internal issue: https://app.asana.com/0/488551667048375/885011869511894

[CDRussell]

Brief summary:

It turns out, that on (some versions of?) Android System WebView, onPageCommitVisible isn't called. 😞

If the user has Chrome installed, this problem won't likely present itself. This will happen for people who don't have Chrome installed, or have it disabled, as they will be using the System WebView. It isn't yet clear if all System WebViews have this problem, or only certain versions.

[ashucg]

Thanks for the update, I will try to downgrade WebView and update you

[ashucg]

Did some tests:

DDG browser: 5.12.0
WebView: 69.0.3497.100 - not working
WebView beta: 71.0.3578.20 - not working

DDG browser: 5.11.1
WebView: 69.0.3497.100 - working fine
WebView beta: 71.0.3578.20 - working fine

[CDRussell]

It turns out the WebView version isn't the problem; rather, onPageCommitVisible is only called from API 23 onwards.

[CDRussell]

Fixed by https://github.com/duckduckgo/Android/pull/387

A hotfix will be going out for this today. Thanks for the help!

[CDRussell]

This has now been released to production as version 5.12.1 (will be generally available within the next hour or two).

Testing on that new version to ensure it's fixed would be much appreciated. 🙏

[ashucg]

@CDRussell I've tested 5.12.1 version and it is working fine now :1st_place_medal: Thanks for fixing it!

[CDRussell]

Much appreciated!