Android: Minor UI issues with "Deleted Files" view

Created on 27 Aug 2018  路  7Comments  路  Source: nextcloud/android

Actual behaviour

device-2018-08-27-091933

Expected behaviour

  1. icon should maybe changed to grey600? cc @jancborchardt
  2. files should display the respective mime type icon not the folder icon
  3. text is cut of needs some more padding at the bottom

Environment data

Android version: 8.1

Device model: OP3T

Stock or customized system: Linage latest nightly

Nextcloud app version: actual master

Nextcloud server version: 14.0.0R1

cc @tobiasKaminsky since he implemented the view :)

bug design good first issue pr exists

Most helpful comment

Haven't checked this issue and it also works for me, due to all the changes and layout fixed I did when removing the dividers via #2944 (third issue), so we can close this as it'll ship with 3.3.0 :+1:

The second problem was my mistake, due to dome dev version in between I had folders created with the names of the images, so it looked like images but they work in fact folders :)

All 7 comments

  1. correct, should be the same color like overflow menu, or?
  2. works for me, I also get the correct preview.
  3. this then needs to be changed in overall xml, as this is just like the regular oc file list

Thanks for testing and reporting this findings :+1:

  1. correct, should be the same color like overflow menu, or?

yes

  1. works for me, I also get the correct preview.

okay, will have to try and re-install then

  1. this then needs to be changed in overall xml, as this is just like the regular oc file list

okay

  1. correct, should be the same color like overflow menu, or?

yes, grey600

  1. works for me, I also get the correct preview.

hmm, doesn't work for me with latest master, might need a fresh install

  1. this then needs to be changed in overall xml, as this is just like the regular oc file list

nope, trashbin uses it's own item layout trashbin_item.xml since it has 3 lines, while the file item has 2 (thus 72dp are not enough here, will fix)

icon has been fixed and merged to master via #2940

Have you already changed the third problem? Or is this vanished because we do not longer have a divider?

2018-09-11-140429

I cannot reproduce second problem.
Is this still happening to you?

Haven't checked this issue and it also works for me, due to all the changes and layout fixed I did when removing the dividers via #2944 (third issue), so we can close this as it'll ship with 3.3.0 :+1:

The second problem was my mistake, due to dome dev version in between I had folders created with the names of the images, so it looked like images but they work in fact folders :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rainer042 picture rainer042  路  3Comments

Shagequi picture Shagequi  路  3Comments

ikke-t picture ikke-t  路  3Comments

markbryanduncan picture markbryanduncan  路  3Comments

JSoko picture JSoko  路  3Comments