Android: Show if a file has comments

Created on 21 Aug 2018  路  11Comments  路  Source: nextcloud/android

Nextcloud app is constantly improving and the new versions will allow to insert comments and tags (#1798 and #548).

I Think it could be useful to display which files have comments and/or tags.

enhancement needs infdiscussion

All 11 comments

GitMate.io thinks possibly related issues are https://github.com/nextcloud/android/issues/975 (Showing deleted files), https://github.com/nextcloud/android/issues/1756 (Show all text files), https://github.com/nextcloud/android/issues/276 (No files shown), https://github.com/nextcloud/android/issues/834 (Entering folder first time dont show files), and https://github.com/nextcloud/android/issues/983 (On device: show only folders containing downloaded files).

it could be useful to display which files have comments and/or tags.

looping in @nextcloud/designers and @nextcloud/android if and how this could be achieved

I like the tagging. But now it is useless, until you can use it also on the desktop client and mobil client.

The web UI also does not show if a file/folder has a tag/comment.
As they (normally) have lots of more space than we have on mobile devices, I am not that sure, how we can solve this.

The web UI also does not show if a file/folder has a tag/comment.

We actually show a comments indicator if there is a new comment that mentions you on a file.

As they (normally) have lots of more space than we have on mobile devices, I am not that sure, how we can solve this.

There is https://github.com/nextcloud/server/issues/6424 about showing tags in the files list, but I agree with @tobiasKaminsky that this won't work on mobile.

Cool, didn't know that.
How is this done? Do we have to check on each and every file/folder for unread comments?

You can get it from the PROPFIND of the folder, if you request the oc:comments-unread property.

I was thinking to https://github.com/nextcloud/server/issues/6424 when writing this issue. But @juliushaertl was faster than me at linking to it!

The mobile client could simply display somehow

  • if a file has unread comments
  • (maybe) if a file has tags.

If I am tagging the files in a folder, knowing if a file has tags could be practical. A simple non intrusive graphical sign could be enough. Maybe something as a light Gray dot.
It is not a problem if I need attention to notice it. Better that than having the need to click on the file to show the details.

Today I wanted to create a first implementation attempt for this feature request (the 'show unread comments' part of it) as I really like to use this feature in the app too. But then I realized that in last December the necessary code changes were already commited by @tobiasKaminsky into master branch.

The way the feature is implemented looks really good and exactly meets my expectations. So I'd like to ask if there is already a plan when the changes will be merged into stable branch.

@DerTomm next release 3.5.0 might well get a first release candidate next week. So it should become a stable release within the next 2-3 weeks we hope.

We have https://github.com/nextcloud/android/issues/2485 for discussing tag support.
So we can close this, I guess.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tobiasKaminsky picture tobiasKaminsky  路  3Comments

tobiasKaminsky picture tobiasKaminsky  路  3Comments

AndyScherzinger picture AndyScherzinger  路  3Comments

eppfel picture eppfel  路  3Comments

markbryanduncan picture markbryanduncan  路  3Comments