Android: [2.8.0 beta v1] Release new beta version

[davigonz]

TASKS:

• [x] [COORDINATION] Create task in Community Management board to publish a blog post, several days before releasing
• [x] [DEV] Create 2.8.0_beta_v1 branch from master and:
  - Update naming of drawer resources to be brandable. Have a look at https://github.com/owncloud/ownbrander/issues/801
  - Update version code and name in build.gradle.
  - Update changelog file (< 500 chars)
• [x] [QA] Perform some tests @jesmrec
• [x] [DEV] Merge 2.8.0_beta_v1 branch into master in owncloud/android
• [x] [DIS] Generate test APKs files from branch master in owncloud/android
• [x] [GIT] Create and sign tag oc-android-2.8.0-beta.1 in HEAD commit of master branch, in owncloud/android
  
  
  
  • [x] [DOC] Include new changelog on Releases section of github android repo by drafting the new pre-release 2.8.0 beta
  
  
• [x] [DIS] Generate final APK files from signed commit in owncloud/android and perform some basic operations

---

PLAY STORE:

• [x] [DIS] Upload & publish beta release APK and changelog

---

F-DROID:

• [x] [DEV] Create MR in F-Droid repo to include 2.8.0 beta build https://gitlab.com/fdroid/fdroiddata/merge_requests/3274
  
  
  
  • [x] [DEV] Merge MR into F-Droid.
  
  

---

FINAL TASKS:

• [x] [SPREADTHEWORD] Write a topic in central about the beta release. https://central.owncloud.org/t/owncloud-android-2-8-0-beta-app-released/13853
• [x] [SPREADTHEWORD] Share new beta on social media.

---

---

BUGS & IMPROVEMENTS:

• [X] (1) Crash when sharing content with no internet connection [FIXED]
• [x] (2) Downloaded file size not properly shown [FIXED]
  
  
  
  • [X] (3) Quota after upgrading https://github.com/owncloud/android/issues/2221#issuecomment-393054094 [FIXED]
  
  
  • [x] (4) Thumbnail in share view https://github.com/owncloud/android/issues/2221#issuecomment-393061414 [FIXED]
  
  
  • [x] (5) Drawer cloud in the way on phones with small screens https://github.com/owncloud/android/issues/2221#issuecomment-393135456 -> will be brandable
  
  
  • [X] (6) Translations of new drawer options https://github.com/owncloud/android/issues/2221#issuecomment-393443100 [TRANSIFEX]
  
  
  • [X] (7) Crash when disabling camera uploads https://github.com/owncloud/android/issues/2221#issuecomment-393453529 [FIXED]
  
  
  • [X] (8) Crash when tap on square button https://github.com/owncloud/android/issues/2221#issuecomment-393454263 [FIXED]
  
  

[jesmrec]

Bug (1) [FIXED]

Check this bug, maybe we should take care before the beta release:

1. Switch connection off
2. Try to share content

Current: app crashes
Expected: share view displayed

[davigonz]

Bug (2) [FIXED]

Steps to reproduce:

1. Download a file
2. Wait till is completely downloaded
3. Swipe down the notifications bar

Current: Downloaded file name is not properly set, something like %1$s downloaded appears.

Expected: Downloaded file size is properly shown

Tested with Nexus 6P v7.1.2

[theScrabi]

fixed https://github.com/owncloud/android/issues/2221#issuecomment-392487886

[davigonz]

@jesmrec initial tasks done, ready to test

[jesmrec]

(3) [FIXED]

Steps:

1. Install 2.7.0 (previous release)
2. Upgrade to beta

Current: Quota is displayed as Loading quota forever in portrait. Quota is displayed as %1$s of %2$s used
Expected: Quota is displayed correctly

Tested with Nexus 6P v7.1.2

[jesmrec]

(4) [FIXED]

Steps:

1. Open share view of any file

Current: Thumbnail (top left corner) is too small

Expected: as before

[theScrabi]

fixed (4)

[theScrabi]

I noticed that the items in the drawer overlap the cloud in portrait mode if the screen of the phone is to small.

[jesmrec]

i think that the cloud image as background does not look bad at all

[michaelstingl]

@jesmrec could become a problem with some brandings and color combinations.

[jesmrec]

@michaelstingl yes, we have taken it in account. This oB issue is opened: https://github.com/owncloud/ownbrander/issues/801

[theScrabi]

i think that the cloud image as background does not look bad at all

It should be lighter if we want it to be a background image. @davigonz and me decided to not show it behind the items. Therefore I removed it on smaller screens now.

[jesmrec]

(6) [To fix in transifex]

The new options in the drawer has some dependency on the device language. For example, the spanish translation for Feedback is Mensajes de retroalimentación https://github.com/owncloud/android/blob/5f54c3aa83f894eacf02637a61004b0b3ff85a9e/res/values-es/strings.xml#L31

there is not enough room for such translation:

this is only an example, maybe translations in other languages for other options in the drawer happens the same.

out of the scope: this spanish translation for Feedback is absolutely absurd.

[davigonz]

It should be lighter if we want it to be a background image. @davigonz and me decided to not show it behind the items. Therefore I removed it on smaller screens now.

@theScrabi It is not possible to include the cloud resource in ldpi or mdpi resources so it looks smaller?

[davigonz]

there is not enough room for such translation:

@jesmrec IMHO, we cannot handle this in a proper way unless we include a better translation, because ellipsizing the text like Mensajes de... wouldn't work for us either.

What about "Sugerencias"?

[jesmrec]

it is an option, i like als other ones like: Dános tu Feedback or Dános tu opinión. But, if we can not handle the room for the length of the options (technical fix), it is out of the scope and we can fix it it transifex.

[jesmrec]

(7) [FIXED]

Steps:

1. Install the app in a device
2. Go to settings, and enable either ' Picture uploadsorVideo Uploads`
3. Disable the same option and accept the confirmation

Current: app crashes
Expected: option disabled

Stack trace:

 java.lang.IllegalStateException: Couldn't read row 0, col -1 from CursorWindow.  Make sure the Cursor is initialized correctly before accessing data from it.
        at android.database.CursorWindow.nativeGetLong(Native Method)
        at android.database.CursorWindow.getLong(CursorWindow.java:511)
        at android.database.AbstractWindowedCursor.getLong(AbstractWindowedCursor.java:75)
        at android.database.CursorWrapper.getLong(CursorWrapper.java:127)
        at com.owncloud.android.datamodel.CameraUploadsSyncStorageManager.createOCCameraUploadSyncFromCursor(CameraUploadsSyncStorageManager.java:147)
        at com.owncloud.android.datamodel.CameraUploadsSyncStorageManager.getCameraUploadSync(CameraUploadsSyncStorageManager.java:133)
        at com.owncloud.android.files.services.CameraUploadsHandler.updatePicturesLastSync(CameraUploadsHandler.java:181)
        at com.owncloud.android.ui.activity.Preferences$15.onClick(Preferences.java:547)
        at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:166)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Tested with Android 8, Android 6

[jesmrec]

(8) [FIXED]

maybe same bug as (7)

Steps:

1. Install the app in a device
2. Go to settings, and enable either Picture upload or Video Uploads
3. Tap on the square button to switch to another app

Current: app crashes
Expected: no crash

Tested with Android 8, Android 6

[jesmrec]

All stuff fixed and test performed. approved.

[davigonz]

All stuff fixed and test performed. approved.

Great @jesmrec , can you please review the changelog before merging the beta branch?

[jesmrec]

Changelog is correct 👍

[theScrabi]

PR for f-droid got created