Android: Rename folder to existing name -> wrong snackbar

[tobiasKaminsky]

Actual behaviour

-"could not give server new name"

Expected behaviour

• "renaming not possible, name already taken" or similar

Steps to reproduce

1. rename a file/folder to an already existing name
2. look at snackbar

[cheikhSall]

Just discovered your app and UnixCorn and I love it. I'm trying to fix this issue, hoping it starts the beginning of a list of contributions.

[comradekingu]

@cheikhSall Searching through Transifex, "Could not rename server" is the same as the "Could not rename" convention used twice already in Files.
There is one "Could not give server new name" in Android, and also "Local copy could not be renamed" but those are just longer for no obvious benefit.

[AndyScherzinger]

Welcome @cheikhSall and awesome to read you want to work on it,highly welcome!

If you have any questions or need any pointers @tobiasKaminsky @mario and me are here to help! Don't hesitate to ask 😃

[AndyScherzinger]

@comradekingu so what should be the used text here? I'd don't have a good idea but would expect the text to state the issue an in the name being taken already. Else it would be just an "oops" ;)

[cheikhSall]

thank you for your welcoming

[comradekingu]

@AndyScherzinger @cheikhSall
I see nothing wrong with "Could not rename server". Short of this issue being fixed, I made the needed changes in #2115 to have it be that way throughout.