Android: system back button does not work in auto-upload settings

[srkunze]

Actual behaviour

pressing system's back button while having the auto-upload settings of a specific folder open, does nothing

Expected behaviour

pressing system's back button closes the auto-upload settings of a specific folder

Steps to reproduce

1. open settings for auto-upload
2. open settings modal for a specific application/folder such as WhatsApp Videos
3. press Android's back button

Environment data

Android version: Android 7.1.1

Device model: OnePlus 5

Stock or customized system: Stock

Nextcloud app version: 2.0.0RC4

Nextcloud server version: 11.0.4

[AndyScherzinger]

Hi @srkunze, thanks for the report. Helps to improve the UX, fix is provided via #1438

[srkunze]

That was fast. Thanks a lot. :-)

[AndyScherzinger]

@srkunze well, thanks! :) While it may still be a little bit more time until we will release 2.0.0 RC5 - still hunting down and fixing bugs

[srkunze]

@AndyScherzinger You're welcome. Got 3 more. :-)

[AndyScherzinger]

@srkunze I saw em. Not sure though if and when they would be done. ;)

[srkunze]

@AndyScherzinger Would pull requests be accepted?

[AndyScherzinger]

@srkunze in general yes while I'd recommend to wait until an issue has been flagged with "approved" which makes then sure that a PR for that issue would be merged. I am afk today/tomorrow most of the time, so I hope that @mario and @tobiasKaminsky can have a look at your proposals :)

[mario]

PR welcome @srkunze

[AndyScherzinger]

This issue is already fixed in a PR

[mario]

Yup was too late ;)

On Sun, 27 Aug 2017 at 18:45, Andy Scherzinger [e-mail]
wrote:

This issue is already fixed in a PR

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/nextcloud/android/issues/1434#issuecomment-325209929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAWsmsAoaLiP_KIhkWdTqMm6Q2nkH3pks5scZ1HgaJpZM4PDdgu
.