Android: Nextcloud Dev 20170705: "Settings" page for Passlock and "Show hidden files" confusion.

[OlivierS1]

Actual behaviour

-Tell us what happens

This new release of Nextcloud Dev seems to have a few graphical element being reworked.
One that is confusing is the "Passcode lock" and "Show hidden files" switch graphical representation.
I just can't make sense of the meaning of the gey'ish and darker grey color of the switch.
Which color correspond to the enabled vs disabled?
I am confused.

Expected behaviour

-Tell us what should happen
A better, more meaningfull color coding stile should be used as not to misinterpret the status of the controls.

Steps to reproduce

1. Go into "Settings"
2. Go to Details section and toggle the switches.
3.

Environment data

Android version:
6.0
Device model:
LG-D852
Stock or customized system:
Stock
Nextcloud app version:
Nextcloud Dev 20170705

Nextcloud server version:
NC 12

Logs

Web server error log

Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

NOTE: Be super sure to remove sensitive data like passwords, note that everybody can look here! You can use the Issue Template application to prefill some of the required information: https://apps.nextcloud.com/apps/issuetemplate

[AndyScherzinger]

@tobiasKaminsky this one is for you ;)

[tobiasKaminsky]

The problem is that we cannot theme the preference toggle buttons with any arbitrary color as we can do with the rest. So we are using grey as a fallback for the toggle buttons in preference, and only there ;-)

As we do not change the overall UI/UX I thought it will still be clear what is "on" and what is "off"...

@jancborchardt @juliushaertl do you have any additional design ideas?

[mario]

@tobiasKaminsky can we use this?

https://stackoverflow.com/a/25635526

[tobiasKaminsky]

No, we need to use a SwitchPreference <- TwoStatePreference <- Preference :-/

[AndyScherzinger]

@tobiasKaminsky this might work https://stackoverflow.com/questions/26466577/apply-tint-to-preferenceactivity-widgets-with-appcompat-v21

[tobiasKaminsky]

Can you give me a more detailled hint which I shall try? ;-)

[jancborchardt]

If it’s not possible to theme, maybe we should go even darker, maybe full black (or whatever is used for text color) for the toggle?

[tobiasKaminsky]

We can try it, but I think that the more important visual hint is if the round button is left (off) or right (on)...

[AndyScherzinger]

the more important visual hint is if the round button is left (off) or right (on)...

not for users from the r-t-l space ;)

[jancborchardt]

Yeah, that is actually the case for anyone: You don't necessarily know which direction is on and which is off, that's why it has to be unmistakably clear. :)

Let's try going darker or full black - or in the best case color it like @mario referenced above (if possible). :)

[OlivierS1]

Full black wouldn't be a good idea I think.
I have played with the new color scheme and the text were "Nextcloud Dev" used to appear on the top menu and now being replaced with the slogan did show in black when I used my own string. It was disconcerting. Maybe that was expected due to some settings, but it seemed to me more like of having a bug where font is missing. Didn't like it at all.

[tobiasKaminsky]

The color of the slogan should change depending on the background color:
if it is a lighter color -> black
if it is a darker color -> white

Please note that the discussion of the color is just only for the preferences screen, not for the entire/rest of the app.

[AndyScherzinger]

@tobiasKaminsky @jancborchardt shouldn't we rather use the server name?! Our stable app also says Nextcloud and not "your data, your rules" or whatever. In my opinion this should be the server name branding wise... :)

[mario]

Indeed

On Fri, Jul 7, 2017 at 9:57 AM, Andy Scherzinger [e-mail]
wrote:

@tobiasKaminsky https://github.com/tobiaskaminsky @jancborchardt
https://github.com/jancborchardt shouldn't we rather use the server
name?! Our stable app also says Nextcloud and not "your data, your rules"
or whatever. In my opinion this should be the server name branding wise...
:)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nextcloud/android/issues/1163#issuecomment-313614294,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAWsqOPYYRXIgdnzIHUFEe9P8fstW1hks5sLeTagaJpZM4ON5RC
.

[jancborchardt]

Absolutely, header should use the name, not slogan. The slogan is only used in the web interface really. :)

[tobiasKaminsky]

shouldn't we rather use the server name?!

I have changed this.

[tobiasKaminsky]

It seems that we currently do not support r-t-l at all:
Forced rtl on emulator, left settings, right our app:

I will open up an issue for this.

This is the toggle button with a slightly darker color.

I will give the theming of this toggle button one last chance, otherwise we have to stay with this color.

[AndyScherzinger]

Well, one way to "fix" it would be to revert back to checkboxes in the settings view. @mario changed it to use switches for material design alignment (thanks for also having an eye on material design 👍). So Pinging you both @tobiasKaminsky

cc: @jancborchardt

[AndyScherzinger]

further remark: even GMail uses checkboxes... So I guess it would be still fine to go back to checkboxes and they would have a clear visual state then 💃

[tobiasKaminsky]

I finally managed it :tada:

Please confirm and then we can close this

[jancborchardt]

Nice work! :)

[tobiasKaminsky]

Thanks, closing as the PR (#1031) is also merged :tada: