Android: IDN-domains not displayed correctly

Created on 27 May 2017  路  12Comments  路  Source: nextcloud/android

Actual behaviour

-IDN-domains (https://www.denic.de/en/know-how/idn-domains/) do work but in the account name they are displayed in their ACE string instead of IDN version.
Of course this is no bug, just a visual improvement.

Expected behaviour

-Display IDN-domains correctly

Steps to reproduce

  1. Get an IDN-domain
  2. Log in
  3. check account name

Environment data

Android version: 7.1.2

Device model: Oppo Find 7

Nextcloud app version: Nextcloud-dev 20170525

Nextcloud server version: 12.0.0

enhancement pr exists

Most helpful comment

You can deploy it to dev builds as I'm using those already anyways. I will gladly test it.
Additionally I can still create a test account for you if needed.

All 12 comments

Hi @kevinkk525, thanks for the input! And yes, while it is technically not a but I agree that this doesn't look very nice and see below, I also think this be fixed (even though it might be helpful if you could provide us with a test account so we can test the code change once it is done, waiting for the other folks approval first though).

@mario @tobiasKaminsky sounds good to me, a quick search revealed that this might be achievable using
https://docs.oracle.com/javase/8/docs/api/java/net/IDN.html#toUnicode-java.lang.String- - not sure if the setting of the flags might be necessary.

@kevinkk525 Or if you are willing to test we can first deploy it to the dev builds :) ...which might be easier!

You can deploy it to dev builds as I'm using those already anyways. I will gladly test it.
Additionally I can still create a test account for you if needed.

Just bumping this up as no progress was made during the last 2 years. (I know it's not a bug and has low priority).

Hi @kevinkk525, thanks for the reminder 馃憤
Would you be willing to create a test account for us and send it to either @tobiasKaminsky or me via email?
I'd then work on a solution for it 馃槉

Thanks for working on this. I created a testaccount and sent the login to Tobias as I couldn't find a way to contact you personally.

Thanks! Today is a bank holiday in Germany, so @tobiasKaminsky will likely forward it to me by tomorrow :)

Forwarded and assigned Andy

@kevinkk525 @tobiasKaminsky I created a fix, see #3948 馃憤

@kevinkk525 please keep the account active so @tobiasKaminsky can test my implementation 鉂わ笍 Thanks for providing a test account. 馃檹

Tested. @kevinkk525 you can remove the test account.

Thanks a lot for implementing this.

Fix has also been backported and will ship with 3.6.1 too.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

toobie83 picture toobie83  路  3Comments

eppfel picture eppfel  路  3Comments

Shagequi picture Shagequi  路  3Comments

markbryanduncan picture markbryanduncan  路  3Comments

ezaquarii picture ezaquarii  路  3Comments