Android: No more Fdroid builds

[laurentdinclaux]

No new nightlies since 20170223

From https://f-droid.org/wiki/page/com.nextcloud.android.beta#20170224 :
We can't build this version: The build for this version appears to have failed.

Build logs:

Git checkout of 'beta-20170224' failed

detail begin
error: pathspec 'beta-20170224' did not match any file(s) known to git.

detail end

[tobiasKaminsky]

A more detailed error log is https://f-droid.org/wiki/page/com.nextcloud.android.beta/lastbuild_20170301

After talking to the fdroid guys the problem is "com.google.android.gms:play-services:10.2.0", which is needed for the enhanced auto upload.
So currently we cannot publish on fdroid :/

[laurentdinclaux]

So I think it should be removed from Fdroid.

The currently​ published nightly has a bug, all my photos have been
auto-uploaded multiple time, and new ones stopped uploading.

Leaving my photos library in such a messy state that nobody should face.

Keeping it like this in Fdroid can only be harmful to nextcloud.

Le 8 mars 2017 06:28, "Tobias Kaminsky" [e-mail] a écrit :

A more detailed error log is https://f-droid.org/wiki/page/
com.nextcloud.android.beta/lastbuild_20170301

After talking to the fdroid guys the problem is
"com.google.android.gms:play-services:10.2.0", which is needed for the
enhanced auto upload.
So currently we cannot publish on fdroid :/

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nextcloud/android/issues/727#issuecomment-284830857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEls0efCnZ_34e_znFX3VsYORkuk6fDpks5rja_rgaJpZM4MU9Ex
.

[mario]

I agrree @laurentdinclaux

[AndyScherzinger]

:/ have to agree, which would mean we would have to stop nightlies until the GMS matter will be resolved. Not sure how that could be accomplished though....

[laurentdinclaux]

Is it some non open source code that you are including ?
Or something needed at build time that the fdroid server do not support
(and obviously won't) ?

2017-03-08 8:07 GMT+11:00 Andy Scherzinger [e-mail]:

:/ have to agree, which would mean we would have to stop nightlies until
the GMS matter will be resolved. Not sure how that could be accomplished
though....

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nextcloud/android/issues/727#issuecomment-284859252,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEls0URA4YzKbAd6nP2vPgIz8vgdIiE-ks5rjccPgaJpZM4MU9Ex
.

--
Laurent
[email protected]

[mario]

We're including play services. While the app can live without it on runtime (possibly with issues), it can't build without it and that's what Fdroid seems to have a problem with.

[mario]

@AndyScherzinger like I said, we could try creating an F-droid flavour without it once my branding branch is merged in and see what happens?

[AndyScherzinger]

I thought what would happen then is that you would have the never ending file duplications during reboot as described by @jasonbayton which is why the implementation has been utilized that is using GMS, no? If so than removing GMS via an f-droid specific build wouldn't help :/

[AndyScherzinger]

@mario f-droid builds the app itself, they don't trust builds/binaries, so the problem would persist with f.droid and GMS...

[laurentdinclaux]

Or build nightlies on your own (travis ? dorneio ?) and make your own
Fdroid repo which is very very easy to setup for compiled APK.

2017-03-08 8:15 GMT+11:00 Andy Scherzinger [e-mail]:

I thought what would happen then is that you would have the never ending
file duplications during reboot as described by @jasonbayton
https://github.com/jasonbayton which is why the implementation has been
utilized that is using GMS, no? If so than removing GMS via an f-droid
specific build wouldn't help :/

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nextcloud/android/issues/727#issuecomment-284861385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEls0eSjvnw73WCHLURsVY4ldWy4ZiaKks5rjcjZgaJpZM4MU9Ex
.

--
Laurent
[email protected]

[mario]

@AndyScherzinger yes, that's what would happen on some phones.

We actually already build our own nightlies and host them.

[AndyScherzinger]

But the same problem exists for the stable/RC builds! So what would/could happen build wise if we simply drop the idea of auto upload for prr Android 5, would the problem still exists on some phones? I guess, right?

[mario]

Yes it would. I believe he was facing this problem on Android 6? Right @jasonbayton ?

[jasonbayton]

👋

I was on 6.0 and 6.0.1 (2 test devices) seeing this issue on boot. 5.1.1 worked fine on my Samsung.
I also replicated it on 7 using an older build sans GMS I'd had lying around (Moto Z) during testing with @mario

The F-Droid build currently up there should be pulled though, you're inflicting cruel, unusual punishment on people having to manually delete potentially thousands of dupes (I still haven't cleared out the latest on my server as NC doesn't make it easy to do so).

I'd support an alternative to GMS in future, assuming whatever it is in GMS that fixes the issue can be gently fondled into a working solution for NC, but if GMS is pulled from the app right now I'd fork the current state and actively avoid using the updated app. It's not worth the hassle.

[AndyScherzinger]

The problem with GMS is that is is a arbitrary dependency of the lib used for the upload jobs...

[mario]

No, I can remove that dependency and keep using the lib. But that causes issues :)

[jasonbayton]

So some special sauce in GMS is making the lib magical.

[AndyScherzinger]

Ah, right, but then it would mean find a workaround and patch the lib ourselves or contribute it back while contributing back would be best then.

[mario]

I believe it's the fact that GCM Network Manager is used instead of faulty Job Scheduler, even if sometimes GCM uses Job Scheduler internally, and GCM Network Manager relies on having Play Services around.

[jasonbayton]

So all we need to do is wait while @mario rewrites Job Scheduler (and contributes it back because ❤️) and we're golden! :)

[mario]

Ideally, yes - but Google doesn't really takes patches.

[jasonbayton]

Well then NC gets all the benefit :)

[mario]

Be serious :P

[laurentdinclaux]

If nightlies are built, hosting an fdroid repo is easy. It is just static
files.

Drop new APKs launch a command: static repo updated.

2017-03-08 8:48 GMT+11:00 Mario Đanić [e-mail]:

Be serious :P

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nextcloud/android/issues/727#issuecomment-284870521,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEls0Y3DV_5BqPWrbMX4WXgbNvqjtnYvks5rjdDBgaJpZM4MU9Ex
.

--
Laurent
[email protected]

[alecbl]

What does this mean for the folks that do not use play services? Like roms with no gapps.

[mario]

Do you have one like that @alecbl ?

[alecbl]

I do yes @mario. I use no gapps, or microg on phones I want signal to run on.

[mario]

@alecbl would appreciate if you could test this then with regards to auto uploads:

https://download.nextcloud.com/android/nightly/latest.apk

Also, try to take a few pictures and reboot. And see what happens (with auto upload enabled)

[alecbl]

Ok, will do and report back soon (tomorrow I hope).

[alecbl]

@mario So I've quickly tested with microg installed. I've taken some pictures and it prompted the auto upload. Tried rebooting afterwards, it didn't repeat uploads. Is there anything in particular I should do to prompt the duplicate pictures issue?.

What did happen is that sometimes uploads fail (I think this is a known issue?). But more interestingly the notification often says the upload failed even though it succeeds, and we can see several indications of uploading completing successfully in the logs. Also it gets listed under "Uploaded", instead of being listed as failed with the option to tap to retry. Just the notification says it failed.

Later I will try with no microg.

[tobiasKaminsky]

I have created a "dirty" fix, I hope.
I removed GCM and on reboot/shutdown all pending upload jobs will just being deleted.
We (mario and I) hope that this prevents uploading files multiple times.

@jasonbayton can you try it with the latest nightly: https://kaminsky.me/nc-nightly/latest.apk

[mario]

Note that this means some files might not get uploaded, and that this is only in nightly.

[jasonbayton]

This was discussed during testing so if the phone shuts down, which happens regularly when I'm on the road, any queued files for upload are lost. Given the app now leaves files in the queue for up to a minute or two before uploading them as it stands, that's a good few files that wouldn't upload.

Even worse and more critical when you expand out to files.

[aronovgj]

Since this was resolved I did not have any issues with autouploads on none of the nightlies. I am one of those who don't use play services (I disable them when I don't need them by using pm disable). So whenever auto-uploads happen these services are not available and auto uploading still always succeeded. That is on Android 7.0.

Also I am a little disappointed that there is a dependency on play services. They are often the root of battery drains, crashes and it also just sucks in general.

[Bullnados]

In Fdroid app the version is outdated (2017-02-22).
On the website the version is 2017-03-14.
If u install that version and go to app settings u can download 2017-03-15.

[AndyScherzinger]

@Bullnados did you hit the refresh button in the app? Because to me the f-droid app shows 2017-03-14

[laurentdinclaux]

2017-03-16 18:55 GMT+11:00 Alexander Scholz [e-mail]:

In Fdroid app the version is outdated (2017-02-22).
On the website the version is 2017-03-14.
If u install that version and go to app settings u can download 2017-03-15.

It doesn't work because of different signing certificates

--
Laurent
[email protected]

[AndyScherzinger]

@laurentdinclaux true, while it is still kind of resolved since 2017-03-14 is also available on f-droid :)

[Bullnados]

*facepalm
U are right refreshing worked

[tobiasKaminsky]

So, I am closing this one as finally new nightlies are available again.

[Bullnados]

Is that normal that fdroid is behind reality?

Version 20170315 - Added on 2017-03-17

Downloading new nightly about app menu shows 20170317. But this version cant be installed on LG G4 and Nexus 10

[tobiasKaminsky]

Normally fdroid is 12-24 hours delayed. But sometimes their build process is slower, but nothing we can influence...

[Bullnados]

Something is still wrong with f-droid beta/nighlies.
fdroid website
Version 20170315 - Added on 2017-03-17

[AndyScherzinger]

@Bullnados nope everything is fine :) The version within the app is telling you the build date set by our infrastructure and is communicated to f-droid, the added on date is the date f-droid actually build the app and published it. So they usually never correspond since our build version is fully automated as soon as we detect a merge-able change within a watched branch (automatically merges and creates a new build/version) but the publish on f-droid is a manual step done by f-droid themselves. It might be even more than 2 days (which did happen in the past sometimes).

[Bullnados]

Okay, but today is the 24th and the last build was one week ago. So if I understand u correct every day or two should be generated automaticly a new nightly?

[AndyScherzinger]

NO, only when our processes detects a change on the list of watched branches and it can be automatically merged. We don't do a release everyday, only when relevant changes happen.

[Bullnados]

Ah okay. Thank you for explenation.
Perhaps a sentence in the fdroid description would be nice for all stupid people like me in the world^^

[AndyScherzinger]

No stupid questions here :) Only a clear sign that this is not well enough described and yes a clear info in the f-droid description would help :)

tobiasKaminsky can you take care of this? :)

[ldmpub]

Hi, not sure to be in the right place but as thread look still "busy" ;-).

It looks like there are no new nightly apk since half a month (see: https://download.nextcloud.com/android/nightly/?C=M;O=D and log there https://raw.githubusercontent.com/nextcloud/android/beta/CHANGELOG.md).
As far as I understand there were at least 1 merge on the new sort order dialog (and I want to check the translation I made for this new feature ... but yet I can not).

[mario]

@ldmpub we were really busy and did not really update the nightly. It will come, there are so many new developments happening, but it will come back :)

[ldmpub]

Thanks for your answer but I still do not understand because @AndyScherzinger replies above

our build version is fully automated

it is automatic or not? because if nightly builds are automated a busy or lazy team ;-) should not have any impact.

[AndyScherzinger]

It does! As soon as there is a merge conflict a feature won't be merged as in updated. If no merges were possible without manual steps, no new build will be done.

Since all beta integrated features now have merge conflicts with the beta Branch, no nightly is build...

[ldmpub]

@AndyScherzinger perfect ... waiting for manual merges before automatic build.

[tobiasKaminsky]

https://raw.githubusercontent.com/nextcloud/android/beta/betaUpdateStatus

You can have a look there. There you can see all branches that are included in nightly and whether it is up-to-date or has a merge conflict.