Android: uppercase letter in server URL results in no connection

[JKawohl]

00006805

Actual behaviour

app can't connect to server because of uppercase character in URL

Expected behaviour

Should connect

Steps to reproduce

1. Try to connect to server with uppercase char in url

[JKawohl]

@davivel
shouldn't be a hard one to fix?

[cdamken]

@davivel any news?

[JKawohl]

@davivel any update or ETA?

[michaelstingl]

@davitol @davigonz Could a fix find it's way in the version after 2.3.0? What is the next version? 2.3.1 or 2.4.0?

[davivel]

What part of the URL is in uppercase? The domain part should not be case sensitive, but the path could be case sensitive or not depending on the server, and we should not manipulate it in the client.

[davivel]

What is the next version? 2.3.1 or 2.4.0?

By default, 2.4.0 . There is a milestone for it :)

[michaelstingl]

Original report from user:

There is a minor bug in the Android client (version 2.1.2): In case the server URL contains uppecase letters the app cannot establish a connection. However, the iOS version (v3.5.1) can handle uppercase letters in the URL.

It seems the (sub)domain part is case sensitive in the Android app. @davigonz Is this difficult to fix?

[davivel]

I'd really like to know what's the reason after this problem. Reformatting input, such as just making it lower case, might lead to unexpected problems.

[davigonz]

Sorry @michaelstingl , I've misplaced this issue. As @davivel says, solutions as making the input lower case could not be the proper ones. IMHO we should go deeper to get the main reason of this problem.

[michaelstingl]

I can explain every behaviour to my users, but I can't explain why it's inconsistent with Android, iOS and desktop.

Shouldn't this be specified somewhere? RFC? I think this isn't only a problem for ownCloud.

[ayushpateria]

I don't think making the domain part of the URL lowercase may lead to any unexpected problem. Even Google Chrome does this, type any URL with upper case letters in domain in the address bar and it will be converted to lower case by the browser.

[davivel]

@michaelstingl , this is a bug, it's a wrong behaviour of the app. I was not trying to defend otherwise, sorry if seemed so. You are right, domain names are case insensitive according to rfc4343: https://tools.ietf.org/html/rfc4343 .

@ayushpateria , I'm not worried about applying lowercases to access the server; I'm worried because the URL is also used to define the name of the account that is stored in the app, and we need to think always what will happen with current users of the app when they upgrade it with this change. In second thought, probably in this case it's not really dangerous, because the corner case is too tricky.

Let me have a look to your PR and let's move forward.

[davivel]

@Kawohl, this was fixed by @ayushpateria . Will be included in next release, number 2.4.0 per the current planning.