Android: Add a new build configuration for BETA program

[davivel]

To reactivate the BETA program we should add a new build configuration that allows to install the beta versions of the app in a device that already holds the stable app, granting that both operate independently.

To get it, will be needed a buildType different to release (debug could be good enough) where at least:

• a different applicationIdSuffix is specified, so that both BETA and sable versions can be installed in the same device;
• some values in res/values/setup.xml are replaced by different ones (for instance, appending the same applicationIdSuffix) for the current build.

The list of values to update in setup.xml should include:

• app_name
• account_type
• authority
• document_provider_authority
• file_provider_authority
• search_suggest_authority
• search_suggest_intent_action
• data_folder
• user_agent (optional, but convenient)

cc @theScrabi , FYI. For any question or improvement, let's comment here :)

Follow up https://gitlab.com/fdroid/fdroiddata/merge_requests/2344

AC:

• [x] Create a new buildType or productFlavor with a different applicationIdSuffix.
• [x] Create a separate version of res/values/setup.xml specific for the new builtType, with new values for app_name, account_type, authority, document_provider_authority, file_provider_authority, search_suggest_authority, search_suggest_intent_action, data_folder, user_agent
  
  
  
  • [x] Generate an appropriate version name & number for the beta build.
  
  
  • [x] Replace usage of .sendStickyBroadcast(intent) in the app with calls to LocalBroadcastManager#sendBroadcast(intent).
  
  
  • [x] Variant app icon
  
  
  • [x] Decide: builtType or productFlavor. We've chosen buildType
  
  

cc @davigonz

---

BUGS & IMPROVEMENTS

• [X] (1) Manage space in device settings, crash https://github.com/owncloud/android/issues/1839#issuecomment-310358136 [FIXED]
• [X] (2) Sharing with oC or oCß crashes https://github.com/owncloud/android/issues/1839#issuecomment-310363287 [FIXED]
• [x] (3) URL not customizable https://github.com/owncloud/android/issues/1839#issuecomment-310589915

[xylo]

Sorry when I ask this question, but I don't see how this new beta build configuration differs from the old one. The old beta could also be installed separately to the stable version and operated independently.

[theScrabi]

@davivel Maybe we should also use a different icon for the beta app, so you can directly distinguish between this an the stable app.

[xylo]

@theScrabi
FYI: https://github.com/owncloud/android/issues/1227

[davivel]

Sorry when I ask this question, but I don't see how this new beta build configuration differs from the old one.

The old one is currently unmaintained.

The variant build configuration should allow to build the new beta easily.

Also, the new beta will be built from master, not from a separate branch. That should mean that any change included in the beta app should be available in the next official release, unless something really wrong is revealed during testing.

By the way, sorry for coming back so late, but finally the time has come :)

[michaelstingl]

@lefherz FYI ^

[davigonz]

Maybe we should also use a different icon for the beta app, so you can directly distinguish between this an the stable app.

I've created an icon variant for the beta app. Here it is:

Any feedback is welcome

CC @michaelstingl @theScrabi @davivel

[jesmrec]

Test plan execution:

https://github.com/owncloud/QA/blob/master/Mobile/Android/Beta%20Program/Beta_test.md

[jesmrec]

(1) Bug (fixed)

Steps:

1. Install the beta version
2. Go to device settings -> Apps -> ownCloud Beta -> Storage
3. Tap on Manage Space

Current: Crash
Expected: not Crash

Tested with Huawei 6P v7, Nexus 5 v5

@davivel @davigonz

[jesmrec]

(2) Bug (fixed)

Steps:

1. Install the beta version, release/debug version, or both
2. Share content from other apps, or share text, with ownCloud or ownCloud Beta

Current: Crash
Expected: Content shared

Tested with Huawei 6P v7

@davivel @davigonz

[davivel]

Both bugs ready to be tested, @jesmrec

[jesmrec]

(3) Improvement

1. In `setup.xml' , set a server_url.
2. Build the app and install

Current: URL does not appear in login view
Expected: URL appears

[jesmrec]

Approved

@davivel @davigonz

[theScrabi]

The merge for the reworked metafile for fdroid is submited:
https://gitlab.com/fdroid/fdroiddata/merge_requests/2344

However I've noticed several things:

1. The app must not be debugable, which means the line initWith debug here must be removed.
2. fdroid can handle build flavors better than build variants.

[davigonz]

Hi @theScrabi , thank you for the merge creation, I have several questions about the things you've noticed.

1. The app must not be debugable, which means the line initWith debug here must be removed.

Why should the app be debuggable? Is it a fdroid requirement? We think that It would be good to keep this option enabled so that community can give us some logs to track and fix the errors easily, which is basically the aim of the beta version.

1. fdroid can handle build flavors better than build variants.

We were discussing about it before the beta implementation, reading some documentation about the topic and we finally decided to use build variants because:

• They are more appropriate for different builds of an application that aren't functionally different. In our case, beta, debug and release have differences that aren't important to the end user, and only the release variant will be deployed to end users.
• On the other hand, product flavours are used when multiple variants are going to be deployed to users and the app variants are notably different in some way.

CC @michaelstingl

[theScrabi]

Hello @davigonz:

Why should the app be debuggable? Is it a fdroid requirement? We think that It would be good to keep this option enabled so that community can give us some logs to track and fix the errors easily, which is basically the aim of the beta version.

I see your point. However, I was not able to compile the app unless I disabled debug. As you said it, fdroid probities that.
We may have to ask the fdroid people if it is possible to have a debugable app in their repository.

About the build variants:
As I said fdroid was better in handling flavors, but in the end using build variants was not such a big problem, so we can keep that.

[davigonz]

Hi again @theScrabi , I've just seen you've asked to fdroid people about uploading the app debuggable, thank you.

In case it is not possible to put the app debuggable in fdroid and we have to disable debugging, we will have to sign the apk but I can't see that part in the merge request build, it seems that the apk is being generated without signing it. How does it work on fDroid? Because Android system requires that all installed applications be digitally signed with a certificate

[theScrabi]

Fdroid will sign the app with their own certificate.

[davigonz]

Hello again @theScrabi , I've just removed the debug flag and updated the oc-android-2.5.0-beta.1 tag with the recent changes in the code so you should be able to compile the app now.

Do you know when could it be published in FDroid? Thank you very much

[theScrabi]

The state and the buildstate of the app on fdroid can be found here:
https://f-droid.org/wiki/page/com.owncloud.android.beta

[lefherz]

will it be automatically updated, once the gitlab PR comes into effect?

[theScrabi]

Yes

[lefherz]

It's on fdroid! We did it! nice work, guys!

I'll publish a blog post announcing the new testing client tomorrow.

[davigonz]

Hi @theScrabi , could you please check the url https://fdroid.org/packages/com.owncloud.android.beta/? It should include the beta owncloud apk and more details but Not found is shown instead.

[theScrabi]

Hm. God question why this does not work, but I assume that it might be because fdroid changed the website recently.

[davivel]

The URL https://fdroid.org/packages/com.owncloud.android.beta is working now. I would say our work here is done, the problems with the web and with the certificate are specific of F-Droid website.

Thanks everybody!