Android-runtime: ext broken in app.gradle on tns-android@next

[edusperoni]

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project:

• CLI: 4.2.4
• Cross-platform modules: 4.2.1
• Android Runtime: 4.3(@next) to @next

Describe the bug

After build 4.3.0-2018-08-10-09, the ext and project.ext part of app.gradle is ignored.

To Reproduce
Easy way:

• create an empty project
• tns plugin add nativescript-plugin-firebase
• set on app.gradle:

ext {
  googlePlayServicesVersion = "10.0.1"
}

this should print:

* What went wrong:
A problem occurred evaluating script.
>  googlePlayServicesVersion set too low, please update to at least 15.0.0 / 15.0.+ (currently set to 10.0.1)

But it doesn't, and it continues ignoring the ext part.

Manually setting ext in platforms/android/build.gradle works as expected.

Expected behavior

ext is not ignored.

Sample project

any project with [email protected] or above will do

Additional context

this seems to be happening since this commit:
https://github.com/NativeScript/android-runtime/commit/0c83f7cc6ae8c7b9f15bd0586ac60428c42f77bd

[edusperoni]

Probably related: https://github.com/NativeScript/android-runtime/issues/878

[edusperoni]

I found the culprit:
https://github.com/NativeScript/android-runtime/pull/1124
https://github.com/NativeScript/android-runtime/issues/1123

this makes it so ext properties are not loaded by the time plugin configurations are being imported. I suppose we may need some pre/post app.gradle solution.

Using this order solves the ext issue:

    setAppIdentifier()
    applyAppGradleConfiguration()
    applyPluginGradleConfigurations()

[farfromrefug]

@edusperoni the new order is good because plugins' config should always be set before app's config.
However you are right the ext should be initialized before running applyPluginGradleConfigurations

[edusperoni]

@farfromrefug I'm aware, I was just pointing out how to make ext work again. Maybe something like ext.gradle or options.gradle that is called before the plugin configuration would solve this issue.

Either way, that PR is an undocumented breaking change.

[NickIliev]

Project to reproduce the issue (while using all next from 05.10) can be found here

[vtrifonov]

@edusperoni @farfromrefug what about calling applyAppGradleConfiguration before and after applyPluginGradleConfigurations if there are plugin include.gradle files, but there might be some issues when applying something twice, so you'll need to handle those cases inside the app.gradle by using some variable to determine whether it is the first or the second apply of the file. Please, let me know what you think about this!

[farfromrefug]

@vtrifonov seems like a source of errors to me.Why not having a function just initializing ext with the default Nativescript values?

[vtrifonov]

@farfromrefug What do you mean by default Nativescript values? In the example the problem is that project.ext.googlePlayServicesVersion is set in the app.gradle file which is executed after applying the plugin include.gradle which checks for googlePlayServicesVersion in the project.ext, so I don't see how initialising any project.ext values can solve that problem without executing the app.gradle before the plugin gradle files.

[farfromrefug]

@vtrifonov I thought the issue was with project.ext not existing or project.ext.googlePlayServicesVersion not existing. But now I see the issue.
Could we separate the variable declaration in another .gradle file?
Not very nice but would work:

setAppIdentifier()
    applyVariablesGradleConfiguration()
    applyPluginGradleConfigurations()
    applyAppGradleConfiguration()

[vtrifonov]

@farfromrefug that would be the best solution, however it will be a breaking change and in addition to this we'll need to update all templates to have this file, which might be confusing for some of the users. I'm not sure whether applying the same file (app.gradle) twice (only if any include.gradle is present) could break anything.

[farfromrefug]

@vtrifonov I totally agree with you. I have looked at the gradle to see and if there would be a way to only apply part of a gradle file (like only ext definition) but that does not seem possible.
Let's try with app.gradle include twice?

[vtrifonov]

@farfromrefug actually we've decided to use another file, as this is the cleaner approach.

[farfromrefug]

@vtrifonov i am still facing an issue with this. The issue is now with the tempplugin builds. I have no way to force compileSdkVersion, buildToolsVersion,...
But my plugin requires 28 (android material components).
I tried with before-plugins.gradle but it is not use for plugins compilation.

[vtrifonov]

@farfromrefug we are adding execution of the same before-plugins.gradle file in the tempPlugin builds, you can check the following PR in the CLI and you can try it with nativescript@rc.

[farfromrefug]

@vtrifonov i have tested rc and it is working perfectly now! thank you!!!