Android-runtime: Static binding generator creates wrong files, when two extended classes have the same name

Created on 18 Jan 2017 · 6Comments · Source: NativeScript/android-runtime

_Problem:_
Static binding generator creates wrong files, when two extended classes have the same name
How can I reproduce the problem:

The same class is extended 2 times in typescript
https://github.com/NativeScript/NativeScript/blob/84c469d61b148544bd1ef8b4f41ce689f9145754/tns-core-modules/ui/gestures/gestures.android.ts#L198
https://github.com/NativeScript/NativeScript/blob/84c469d61b148544bd1ef8b4f41ce689f9145754/tns-core-modules/ui/gestures/gestures.android.ts#L339
Uglify is used and the names SwipeGestureListener and TapAndDoubleTapGestureListener become e or some other letter.
while we analyze the uglified, minified javascript the AST parser generates the same name for both classes: GestureDetector_SimpleOnGestureListener_frnal_ts_helpers_l58_c38__e.java.

The name is generated as follows:
<extended_class_name>_f<file_path>_l<line>_c<column>__<unique_name>.java

Because both classes extend the same base class, both names start with the same <extended_class_name>
Because the typescript extends all pass through the ts_helpers file, all files have the same _f<file_path>_l<line>_c<column>.
Because uglifyer minifies the names of both classes the <unique_name> is not so unique anymore.

_Solution_
There are two general paths we can take:

Suggest the user makes an exception when uglifying for the <unique_name> so it stays unique
Find a different way to generate names, that will generate classes with different names, that's also compatible with the way the runtime binding generator would generate them.

This problem does not happen when extending an interface, because the native implementation name does not take part in finding the js counterpart implementation, and all can use the same implementation of an interface.

low bug

Source

Plamen5kov

All 6 comments

For now we'll issue a warning the identical names will be created and that will cause an undefined behavior. In this case the build will crash and recommend workaround options.

Plamen5kov on 18 Jan 2017

👍1

This is causing a problem even without uglifying, because the names have to be globally unique. That means if I use a name that's already been used somewhere in another module, I will hit the same issue because everything passes through the same line in ts_helpers.