Android-job: JobExecutor.mFinishedJobsCache leaks finished job indefinitely

Created on 12 Oct 2017  路  7Comments  路  Source: evernote/android-job

Library version: 1.2.0

JobExecutor.mFinishedJobsCache keeps a LruCache of 20 finished jobs. These job instances can never be garbage collected, at least not until new jobs push these instances out of the cache.

This introduces memory leaks (LeakCanary detected those in our CI toolchain).

bug

Most helpful comment

Thanks for the feedback. I'll probably release a stable version next week.

All 7 comments

I've released a snapshot build with the change. Could you give it try and let me know if that works for you?

repositories {
    jcenter()

    maven {
        url 'https://oss.sonatype.org/content/repositories/snapshots/'
    }
}

dependencies {
    compile 'com.evernote:android-job:1.2.1-SNAPSHOT'
}

Thanks! I passed it on to the team that's been testing android-job.

Thanks, @vRallev (a member of the team @pyricau mentinoned here) 鈥撀爐he update fixed the leak in the mFinishedJobsCache. Appreciate it!

Thanks for the feedback. I'll probably release a stable version next week.

@vRallev Is the memory leak fix coming to the stable release anytime soon?

Soonish :)

Version 1.2.1 has been released.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

georgikoemdzhiev picture georgikoemdzhiev  路  4Comments

deviant-studio picture deviant-studio  路  5Comments

judemanutd picture judemanutd  路  4Comments

mohamadk picture mohamadk  路  6Comments

ruhul015 picture ruhul015  路  4Comments