Android-components: Move .buildconfig.yml data into gradle files

Created on 21 Jun 2019  路  9Comments  路  Source: mozilla-mobile/android-components

The type of user that most commonly updates the list of android-components modules (and per-module configuration) are android-components devs.
Rather than having them learn and memorize a new config format, we should move config into gradle, where the rest of the project build configuration happens

All 9 comments

CC @rpappalax who wanted to add an additional flag for whether a component needs to run ui/on-device tests.

It sounds like that the "run ui/on-device tests" flag would need to exist regardless of how config is encoded (gradle, yaml). Just to make sure we're on the same page: this ticket shouldn't block adding that flag :)

Yeah, agree! Only wanted to make @rpappalax aware that this move is happening. :)

@pocmo thanks for the heads-up guys, I've started working on this. I took a peek at application-services to see if they had done this but it looks like they opted not to take this route. @mitchhentges once you have a branch can you paste it here? I'd like to see how it's going to look.

@rpappalax I've shifted teams and won't be able to push this ticket further - I believe that @JohanLorenzo is probably the best Release Engineering contact to ask about how this will be prioritized.


EDIT: ah, if you were referring to my application-services taskgraph work, I have a branch visible here, but it hasn't changed the .buildconfig.yml logic atm. Mihai Tabara is pushing that work to completion.

howdy @JohanLorenzo! do you have this currently on your radar? How I implement this: https://github.com/mozilla-mobile/android-components/issues/3652 will be different depending on where the data is being pulled from. 馃尀

Hey Richard! I didn't, thanks for bringing it to my attention! Let's have a chat this week 馃檪 I'm not sure what the scope of #3652 is and I'd need to see if moving .buildconfig.yml is a requirement or a nice-to-have.

Discussed over video. @rpappalax and I agreed using .buildconfig.yml for #3652 for 3 reasons:

  1. This enables #3652 to be done quickly
  2. At the moment, no more than a couple of components are planned to support UI tests. Therefore, we don't need to heavily change .buildconfig.yml to make this real.
  3. Changing a yaml file is a much easier task to do rather than deep diving in gradle.

This enables #3652 to be done quickly

馃挴

I like #3652 to be done quickly. 馃檭

Was this page helpful?
0 / 5 - 0 ratings

Related issues

csadilek picture csadilek  路  3Comments

csadilek picture csadilek  路  3Comments

dnarcese picture dnarcese  路  3Comments

psymoon picture psymoon  路  6Comments

Callek picture Callek  路  4Comments