Android-components: Fullscreen pages can be scrolled (because height of toolbar can be scrolled offscreen)

Created on 13 Nov 2018  路  8Comments  路  Source: mozilla-mobile/android-components

Our reference browser and sample browser have the same issue that is described in this Focus issue:
https://github.com/mozilla-mobile/focus-android/issues/3815

Let's investigate if we can find a solution for that.

<engine-gecko> <engine-system> <toolbar> 馃悶 bug

All 8 comments

@Amejia481 Maybe something you want to investigate now that you are familiar with the Nested*View code? :)

  • In the Focus issue there's a discussion about trying to set scroll flags dynamically

  • I recently asked the Pocket guys. They have a very nice implementation; they scroll the status and navigation bar away too though. Anyhow, they described their mechanism as:

screenshot_2018-11-13 pocket-android mozilla slack

Sure I'll take a look! 馃憤

FYI @Amejia481 I got WebView to work (with minimal testing) with this :
https://github.com/ekager/focus-android/commit/09c0618918a0c2a3e022c6d89c62153a9c5c4767

Looks like we would need to ask for a similar GV method to get this to work across engines.

Awesome @ekager 馃挭 !

Nice!

Looks like we would need to ask for a similar GV method to get this to work across engines.

You mean canScrollVertically()?

I assume GeckoSession.shouldPinOnScreen() doesn't help here?

Do we have a follow-up issue for the GeckoView implementation (with API label?)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pocmo picture pocmo  路  3Comments

mcarare picture mcarare  路  5Comments

csadilek picture csadilek  路  3Comments

Callek picture Callek  路  4Comments

codrut-topliceanu picture codrut-topliceanu  路  3Comments