Have you searched the issues of this repository if your issue is already known? Yes, and I found it several times, but old or not matching issues. Like #737 and #495.
pxxxxxxxx.dip0.t-ipconnect.de - - [12/Nov/2018:11:25:41 +0100] "GET / HTTP/1.1" 302 5386 "-" "okhttp/3.8.1"
pxxxxxxxx.dip0.t-ipconnect.de - - [12/Nov/2018:11:25:41 +0100] "GET /login HTTP/1.1" 200 1932 "-" "okhttp/3.8.1"
It worked without problems with Wallabag v1, but this is quite a while ago. As I cannot even log into the server I cannot say more about the app at the moment.
I am rewriting the urls to let it look nice. I do not want to see the web directory here. Also I disabled the register page as I do not want to have people registering accounts on my instance here.
The following setup is used in the Apache webserver:
RewriteCond %{HTTP_HOST} ^wallabag.domain.tld$ [NC]
RewriteRule !^web/ /web%{REQUEST_URI} [L,NC]
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^(.*)$ app.php [QSA,L]
Order Allow,Deny
Deny from all
I am happy to provide further information about my setup, problem, whatsoever. Unfortunally the lack of a working Android client stops me using Wallabag at all. I need to get it working. :-)
Thanks for opening this issue
The change of Simounet in wallabag/wallabag@4c78612 which is not in an official release yet, breaks our login page detection. I mentioned this in https://github.com/wallabag/android-app/issues/737#issuecomment-428340150 but forgot about it.
This issue can be fixed if the regex for login page detection is adjusted accordingly. So that it is compatible with the upcoming release, but also with older versions.
Until this is fixed, you can use the most recent release, which shall work.
Thank you @Strubbl, so I need to get the version before current master from Git? How? Sorry, I am not a developer, so my knowledge of Git is very very limited. Unfortunally.
Or the other way around, would it be a big deal to release a new version of the Android app with the regex adjustment? I am sure a lot of other people run in the same problem as I did.
Ok, I did the follow with some fellow help:
_src/Wallabag/UserBundle/Resources/views/layout.html.twig_ line 14 from:
<div class="center"><img src="{{ asset('wallassets/themes/_global/img/logo-wallabag.svg') }}" alt="wallabag logo" class="typo-logo" /></div>
to:
<div class="center"><img src="{{ asset('wallassets/themes/_global/img/logo-wallabag.svg') }}" class="typo-logo" alt="wallabag logo" /></div>
And the I deleted the Twig cache: _php bin/console cache:clear --env=prod_
Android app works now. :-)
Should I make a pull request with this change?
I do not know if we should fix the issue in the android app or at the server. And it does not matter, because for me both solutions are fine.
If you could make a pull request with that change against the server repo https://github.com/wallabag/wallabag/ that would be very good. Then, the wallabag core team can decide.
I merged the fix but I found it ugly to parse the webpage to determine stuff.
Maybe we should add these information in the API? (I haven't checked what you extracted btw)
From the official docker repo:
https://hub.docker.com/r/wallabag/wallabag/builds/bmfyk43wc8ejmemwwpjcysb/
This is what my page is producing:
<div class="center"><img src="https://wallabag.holtzweb.com/wallassets/themes/_global/img/logo-wallabag.svg" alt="wallabag logo" class="typo-logo" /></div>
Mobile App Cannot Find My Server :/
Same As Above.... I'd love to just update the docker image, making any changes will break upon update.
This is going to be fixed in the upcoming 2.3.5.
I guess it'll be released in the coming days.
Most helpful comment
Ok, I did the follow with some fellow help:
_src/Wallabag/UserBundle/Resources/views/layout.html.twig_ line 14 from:
<div class="center"><img src="{{ asset('wallassets/themes/_global/img/logo-wallabag.svg') }}" alt="wallabag logo" class="typo-logo" /></div>to:
<div class="center"><img src="{{ asset('wallassets/themes/_global/img/logo-wallabag.svg') }}" class="typo-logo" alt="wallabag logo" /></div>And the I deleted the Twig cache: _php bin/console cache:clear --env=prod_
Android app works now. :-)
Should I make a pull request with this change?