Andotp: Simplify auto backup flow

Created on 4 Aug 2020  路  3Comments  路  Source: andOTP/andOTP

Is your feature request related to a problem? Please describe.
Currently the automated backups require a number of things:

  • Have write permissions
  • Using date appended filenames
  • Not requesting the user for the backup name
  • Have valid backup directory
  • Have set an encrypted backup password

This can become confusing and un-intuitive

Describe the solution you'd like
A clear and concise description of what you want to happen.

Not require Using date appended filenames and make automated backups use date appended files automatically, removing the requirement of Not requesting the user for the backup nam

Default Have valid backup directory to be something sensible, like /sdcard/andOTP

And request write permissions if not already given, when setting an auto backup option. Lastly it should pop up a message if you havent set a backup password.

This whole flow ensures out of the box all you would need to do is set a backup password

enhancement

Most helpful comment

The requirements for auto backups have been changed a lot with the storage access rework in 0.8.0.

  1. Write permissions are no longer required since andOTP now uses the Storage Access Framework for everything (storage permissions have been removed from the Manifest altogether).

  2. A default backup location won't be possible since the user now has to manually grant persistent access to a folder using the SAF before andOTP can use it. Setting the backup folder in the settings will do this.

  3. I agree that the "ask for filename" and the "append date" option should not be relevant for the auto backups.

With that the requirements basically come down to:

  1. Have a backup folder defined in the settings (which grants persistent storage access).
  2. Have a backup password set.

I think that's as easy as we can get and those should be easy enough to document for the user.

All 3 comments

The requirements for auto backups have been changed a lot with the storage access rework in 0.8.0.

  1. Write permissions are no longer required since andOTP now uses the Storage Access Framework for everything (storage permissions have been removed from the Manifest altogether).

  2. A default backup location won't be possible since the user now has to manually grant persistent access to a folder using the SAF before andOTP can use it. Setting the backup folder in the settings will do this.

  3. I agree that the "ask for filename" and the "append date" option should not be relevant for the auto backups.

With that the requirements basically come down to:

  1. Have a backup folder defined in the settings (which grants persistent storage access).
  2. Have a backup password set.

I think that's as easy as we can get and those should be easy enough to document for the user.

Can an app still access its external data folder? So like /sdcard/Android/Data/andOTP/... Maybe that could be the default?

getExternalFilesDir is what I meant, and is still usable even without write permissions
https://developer.android.com/training/data-storage/

Yeah, that could be an option. I will look into it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jancborchardt picture jancborchardt  路  6Comments

SkyWheel picture SkyWheel  路  7Comments

ageev picture ageev  路  4Comments

schoeke picture schoeke  路  5Comments

fakkoweb picture fakkoweb  路  4Comments