Andotp: Layout is inverted in Hebrew (and possibly other RTL environments)

[alonbl]

General information

• App version: 0.6.0
• App source: Google Play
• Android Version: 7.1.2
• Custom ROM: AICP LIBRA

Expected result

What is expected?

Latin layout should be aligned as LTR (left to right)

What does happen instead?

The layout is aligned as RTL (right to left)

In most cases this is just annoying, however, if there are spaces in PIN (by default) it is presented as YYY XXX instead of XXX YYY, it took me a while to realize that PIN are correct.

Workaround: configure application not to add space between digits.

Steps to reproduce

• Have Hebrew/Arabic locale phone
• Notice that the entire layout is switched to RTL
• Notice that PINs are printed as YYY XXX instead of XXX YYY

I tried to add a screenshot but application rightfully does not permit that.

[ahangarha]

I confirm this problem. and I think I can solve this problem since I have been busy with RTL improvement of some other FOSS android apps recently.

You may assign this issue to me. I will work on it.

[flocke]

@ahangarha I can't seem to figure out how to assign you from mobile with OctoDroid. But I would be happy if you could work on this. I will assign you as soon as I get back home in the new year.

[ahangarha]

Then expect my PR soon

On جمعه ۲۸ دسامبر ۲۰۱۸،‏ ۱۴:۳۹ Jakob Nixdorf [e-mail]
wrote:

@ahangarha https://github.com/ahangarha I can't seem to figure out how
to assign you from mobile with OctoDroid. But I would be happy if you could
work on this. I will assign you as soon as I get back home in the new year.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/andOTP/andOTP/issues/262#issuecomment-450342624, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKuHY4gYQdmaifx2Nxyd0Uu1GpeN_4Xpks5u9fvwgaJpZM4YxMbB
.

[flocke]

I made a debug build with the PR by @ahangarha for some people to test: https://cloud.shadowice.org/s/andOTP_LTR_v1, it will install as a new app, so don't worry about overwriting your data.
It would be nice if some people that actually use RTL languages could test this and tell me if it works as expected.

[alonbl]

On Mon, Jan 28, 2019 at 1:24 PM Jakob Nixdorf [e-mail]
wrote:

I made a debug build with the PR by @ahangarha
https://github.com/ahangarha for some people to test:
https://cloud.shadowice.org/s/andOTP_LTR_v1, it will install as a new
app, so don't worry about overwriting your data.
It would be nice if some people that actually use RTL languages could test
this and tell me if it works as expected.

I can see the PIN in the right order, thanks!!!

>

[ahangarha]

It is working fine. I can send screenshot if needed.

[flocke]

Thanks for confirming again, I just merged the PR.