Amplify-js: Amplify is totally crashed because of the Window is not defined error in youtube-iframe package

Created on 21 Jun 2019 · 7Comments · Source: aws-amplify/amplify-js

@powerful23, @robbevan ,@mlabieniec, @jordanranz, @mbahar, @richardzcode
After installation of the @aws-amplify with the additional package of youtube-iframe.

Getting the error of window is not defined in

node_modules/youtube-iframe/index.js 50:3
node_modules/@aws-amplify/ui/dist/aws-amplify-ui.js:1

Can you please provide the previous working version without facing the issue of window is not defined in the following folders.

UI bug

Source

svenkatesh-nyros

👍6 👀1

Most helpful comment

Due to Amplify's stated goal of SSR compatibility, we assumed that no new server-breaking changes would be added to the codebase. While Amplify might not yet officially support SSR, can there please at least be a moratorium on new server-side-breaking code? At the very least, a moratorium on new code that _breaks the server at import-time of the package that contains that piece of code_, even if some pieces of Amplify won't properly execute on the server?

For anybody with this problem, my resolution for similar issues with this package was to dynamically import amplify on the client side via a dynamic import in onComponentDidMount.

ajhool on 22 Jun 2019

👍8

All 7 comments

We're also experiencing this - we're using amplify as the basis for a nodejs SDK we're building, and upgrading from 1.1.27 to 1.1.29 produces this error for this. To add insult to injury, there's no changelog to be found, so it wasn't clear what caused this without looking into the codebase!

Please do: use semantic versioning properly so that we can upgrade this package in confidence - this should've been a minor upgrade as you introduced new packages which changed base requirements of the library.
Please do: seriously consider adding a changelog so that other libraries which depend on this can track changes more easily.
Please don't: assume that this library is only being used in the browser

Edit: I can confirm that reverting to 1.1.28 resolves this issue for us.

johnhamelink on 21 Jun 2019

👍8

amplify-js is specifically a client / mobile / web library and does not have official support for node.js. For the iframe issue, we are aware of an issue/bug in analytics that should fix this in: https://www.npmjs.com/package/@aws-amplify/analytics/v/1.2.18-unstable.0

@svenkatesh-nyros can you give this version a try and see if this fixes your issue. We will review this and make sure we add this case to our integration tests.

On the subject of node.js, we can add some documentation around how to get things working properly in node (via isomorphic fetch etc.), but at the moment our team efforts are focused on mobile/web client use cases. We are however investigating node support specifically for SSR.

mlabieniec on 21 Jun 2019

@mlabieniec we ended up stripping out all of amplify and replacing it with just @aws-amplify/auth - we're only using amplify to gain Cognito user credentials we can use to access other AWS products with.

johnhamelink on 21 Jun 2019

👍2

For anybody with this problem, my resolution for similar issues with this package was to dynamically import amplify on the client side via a dynamic import in onComponentDidMount.

ajhool on 22 Jun 2019

👍8

@mlabieniec understanding of the mobile/web focus, however e.g. gatsby build for generating static web site is currently breaking as amplify on import of youtube-iframe is not defining window.