Amplify-cli: Auto Delete S3 buckets when environment is removed

[jamesonwilliams]

Originally created by @daghanacay in the docs project as https://github.com/aws-amplify/docs/issues/1209

Is your feature request related to a problem? Please describe.
When we delete an environment it does not delete the s3 buckets corresponding to that environment

Describe the solution you'd like
when I execute

amplify env remove [envname]

Describe alternatives you've considered
manual deletion of S3 buckets

Additional context
When the team members grow work-flow defined here https://aws-amplify.github.io/docs/cli-toolchain/quickstart?sdk=js#concepts-1 becomes intractable and leaves a lot of orphan S3 buckets.

[yuth]

What version of Amplify CLI is being used to run this command. We have updated the CLI to remove the S3 bucket when the environments are removed a few months back in https://github.com/aws-amplify/amplify-cli/pull/2615

cc @daghanacay

[daghanacay]

I am using amplify version 4.13.4

On Tue, Mar 10, 2020 at 7:56 AM Yathi [e-mail] wrote:

What version of Amplify CLI is being used to run this command. We have
updated the CLI to remove the S3 bucket when the environments are removed a
few months back in #2615
https://github.com/aws-amplify/amplify-cli/pull/2615

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/3627?email_source=notifications&email_token=ABV2FLUAC75QGAVYIAWFJDDRGVQZVA5CNFSM4LEQ2YH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJBCJI#issuecomment-596775205,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABV2FLXZ6F55FWZSZLH36MTRGVQZVANCNFSM4LEQ2YHQ
.

[yuth]

@daghanacay did you have a lot of files in the S3 bucket, I am wondering if this was an edge case that where deleting bucket failed.

Did you get any errors when running the env remove command

__PS__: The bucket delete fix got merged recently, and if the env remove command was run before this fix, those bucket would still exists in the account

[daghanacay]

I did not check this but it was the deploy folder and the cloudfront folder
that was not deleted. I can do another round of test this weekend and get
back to you.

On Wed, Mar 11, 2020 at 6:28 AM Yathi [e-mail] wrote:

@daghanacay https://github.com/daghanacay did you have a lot of files
in the S3 bucket, I am wondering if this was an edge case that where
deleting bucket failed.

Did you get any errors when running the env remove command

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/3627?email_source=notifications&email_token=ABV2FLQOPKZXYIER3JAKJODRG2IGTA5CNFSM4LEQ2YH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOM2DJI#issuecomment-597270949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABV2FLWDPFHJWVS7K6OJF4TRG2IGTANCNFSM4LEQ2YHQ
.

[kaustavghosh06]

We don't delete the S3 hosting bucket. We delete the S3 deployment bucket and the S3 storage bucket added as a part of the amplify add storage flow.

[daghanacay]

I can confirm that all the buckets except for the hosting bucket is
deleted.

Can you also delete the hosting bucket? is there a reason why you leave it?

Cheers
-Daghan

On Fri, Mar 13, 2020 at 8:41 AM Kaustav Ghosh [e-mail]
wrote:

We don't delete the S3 hosting bucket. We delete the S3 deployment bucket
and the S3 storage bucket added as a part of the amplify add storage flow.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/3627#issuecomment-598430596,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABV2FLU6RYZSWZ7YYI53VVDRHFJJFANCNFSM4LEQ2YHQ
.

[beerth]

why was it closed?

I can confirm that all the buckets except for the hosting bucket is deleted. Can you also delete the hosting bucket? is there a reason why you leave it? Cheers -Daghan
…
On Fri, Mar 13, 2020 at 8:41 AM Kaustav Ghosh @.*> wrote: We don't delete the S3 hosting bucket. We delete the S3 deployment bucket and the S3 storage bucket added as a part of the amplify add storage flow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3627 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV2FLU6RYZSWZ7YYI53VVDRHFJJFANCNFSM4LEQ2YHQ .

Why are hosting buckets not deleted?