Amphtml: Design Review 2020-07-01 20:00 UTC (AMP.goBack)

Created on 18 May 2020  路  6Comments  路  Source: ampproject/amphtml

Time: 2020-07-01 20:00 UTC (add to Google Calendar)
Location: Video conference via Google Meet

The AMP community holds weekly engineering design reviews. We encourage everyone in the community to participate in these design reviews.

If you are interested in bringing your design to design review, read the design review documentation and add a link to your design doc or issue by the Monday before your design review.

When attending a design review please read through the designs before the design review starts. This allows us to spend more time on discussion of the design.

We rotate our design review between times that work better for different parts of the world as described in our design review documentation, but you are welcome to attend any design review. If you cannot make any of the design reviews but have a design to discuss please let mrjoro@ know on Slack and we will find a time that works for you.

Design Review

Most helpful comment

The Infrastructure and Outreach Working Groups will be presenting their periodic update at this Design Review (10-15 minutes).

/cc @ampproject/wg-infra @rsimha
/cc @ampproject/wg-outreach @sebastianbenz

All 6 comments

The Infrastructure and Outreach Working Groups will be presenting their periodic update at this Design Review (10-15 minutes).

/cc @ampproject/wg-infra @rsimha
/cc @ampproject/wg-outreach @sebastianbenz

I'd love to discuss this proposal to enable AMP.goBack to perform cross-document navigation: https://github.com/ampproject/amphtml/issues/28751

Notes for AMP.goBack

Justin:

  • On pub origin it's ok to have this.
  • What about the Viewer case? what behavior it will be? is it going to close the iframe?
  • Jake will do some more research to make sure it works in Viewer

Will:

  • remembered that the Viewer case was the reason it got stalled. because the Viewer manipulates the history stack in its own way
  • probably fine to do though, just check with Dima about history manipulation in iframe
  • more concern about changing the default behavior of AMP.goBack. standard procedure will be not to change the existing public API especially that it's not versioned. New action is preferred

@rsimha @sebastianbenz please update this thread once you have your updates ready.

Happy independence day!

Thank you for taking notes @lannka!

@rsimha @sebastianbenz please update this issue with links to the WG updates when they are ready.

@rsimha @sebastianbenz please update this issue and the Working Group wiki with links to your updates.

Was this page helpful?
0 / 5 - 0 ratings