Amphtml: amp-script: Support location.href (don't return the blob URL)
I am using AMP-SCRIPT. I want to get the current URL with parameter, but that what I get:
blob:http://localhost:8080/bcd8ce8b-4c8f-4ab0-8d4e-471d7be9af3f
That's what I want:
http://localhost:8080/?foo=bar
The HTML code:
<!DOCTYPE html>
<html âš¡>
<head>
<meta charset="utf-8" />
<title>AMP-SCRIPT</title>
<meta
name="viewport"
content="width=device-width,minimum-scale=1,initial-scale=1"
/>
<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "NewsArticle",
"headline": "Article headline",
"image": ["thumbnail1.jpg"],
"datePublished": "2015-02-05T08:00:00+08:00"
}
</script>
<script
async
custom-element="amp-script"
src="https://cdn.ampproject.org/v0/amp-script-0.1.js"
></script>
<style amp-boilerplate>
body {
-webkit-animation: -amp-start 8s steps(1, end) 0s 1 normal both;
-moz-animation: -amp-start 8s steps(1, end) 0s 1 normal both;
-ms-animation: -amp-start 8s steps(1, end) 0s 1 normal both;
animation: -amp-start 8s steps(1, end) 0s 1 normal both;
}
@-webkit-keyframes -amp-start {
from {
visibility: hidden;
}
to {
visibility: visible;
}
}
@-moz-keyframes -amp-start {
from {
visibility: hidden;
}
to {
visibility: visible;
}
}
@-ms-keyframes -amp-start {
from {
visibility: hidden;
}
to {
visibility: visible;
}
}
@-o-keyframes -amp-start {
from {
visibility: hidden;
}
to {
visibility: visible;
}
}
@keyframes -amp-start {
from {
visibility: hidden;
}
to {
visibility: visible;
}
}
</style>
<noscript
><style amp-boilerplate>
body {
-webkit-animation: none;
-moz-animation: none;
-ms-animation: none;
animation: none;
}
</style></noscript
>
<script async src="https://cdn.ampproject.org/v0.js"></script>
</head>
<body>
<amp-script layout="container" src="/javascript.js" sandbox="allow-forms">
<button>Hello amp-script!</button>
<span></span>
</amp-script>
</body>
</html>
javascript.js
const btn = document.querySelector('button');
btn.addEventListener('click', () => {
document.body.textContent = location.href;
});
betosg
All 18 comments
Looks like something that should be remedied!
morsssss
on 14 Feb 2020
Any predictions to correct this problem?
betosg
on 17 Feb 2020
@kristoferbaxter did give it a P2!
It might also be a simple way to start contributing... to submit your own PR.
morsssss
on 17 Feb 2020
@choumx
Any news?
betosg
on 9 Jul 2020
@betosg, I know that @choumx and @kristoferbaxter really want to work on changes like this one, and I also know that they're both super busy. It's really an excellent opportunity to contribute to this project!
morsssss
on 10 Jul 2020
This does seem like it should be an easy fix. I'll take a stab at it either tomorrow or early next week.
samouri
on 10 Jul 2020
Hi
I have the same problem trying to get url query parameter from location.href inside amp-script
Could you please help me to know if it is possible?
CarlosCPC
on 20 Jul 2020
Could you please help me to know if it is possible?
@CarlosCPC: this is currently not possible.
Less of an easy fix than I initially thought. The worker location object is WAI in terms of how Workers usually behave. We could overwrite the global location as well as provide Document.location and keep them up to date with the main thread.
samouri
on 21 Jul 2020
Thank you @samouri
To get a query parameter, any workaround could help me a lot, Could you please explain more about provide Document.location and keep them up to date with the main thread?
CarlosCPC
on 21 Jul 2020
@CarlosCPC , I think @samouri is talking about what WorkerDOM would need to do to make location available to the Worker - and thus to <amp-script>.
If you want to work to make this possible in <amp-script>, check out the WorkerDom repo. We highly encourage thoughtful contributions!
morsssss
on 21 Jul 2020
Thank you. I will try.
CarlosCPC
on 22 Jul 2020
@samouri @CarlosCPC Were you able to solve this problem?
betosg
on 28 Jul 2020
@betosg: No. Progress made on this issue will continue to be captured in this thread (unless moved to worker-dom in the future, but that will be called out here as well).
samouri
on 28 Jul 2020
Also, a similar request just appeared on Stack Overflow.
morsssss
on 30 Jul 2020
Here's a case from the amp.dev team: https://github.com/ampproject/amp.dev/pull/4320
morsssss
on 19 Aug 2020
+1 on having this feature. Conditional (e.g. taking keyword from URL parameter) rendering of the CTA message in a page is something very useful that even has been proved to increase conversions.
danieltxok
on 2 Sep 2020
I'm having this issue too. I'm trying to get the current URL with amp-script to pass it as query params in my amp-iframe src. Any other way to do it maybe? Opened a request at Stack Overflow with further information.
rafaelmuttoni
on 9 Oct 2020
@rafaelmuttoni I don't think there's a way at present. I answered your Stack Overflow question... I hope that helps at least a little!
In the meantime, thanks for commenting here; it helps us prioritize this work. Or let us know if you have time to contribute the code yourself. You'd be an AMP hero!
morsssss
on 13 Oct 2020
Related issues
jpettitt
·
3Comments
edhollinghurst
·
3Comments
cvializ
·
3Comments
choumx
·
3Comments
choumx
·
3Comments
Most helpful comment
Looks like something that should be remedied!