Amphtml: Documentation on script tag allowances is inconsistent

Created on 26 Sep 2019  路  5Comments  路  Source: ampproject/amphtml

While Github states that script types can only be application/ld+json or text/plain, the amp-access documentation shows that application/json is permitted for the amp-access case.

My assumption is that the more pervasive view i.e. application/ld+json or text/plain for all cases and "application/json" for amp-access is the right model.

cc @CrystalOnScript @jpettitt

[edited by @jpettitt for markdown readability]

Documentation Bug good first issue

All 5 comments

There area lot of places where application json is used for inline scripts. Which makes me think the master spec is out of date here.

Should be a quick PR. :)

Hey I would like to claim this issue and create a PR. A newcomer to contributing to open source but from what i understand is the change just to update the amp-access documentation to include both the types of scripts?

Hi @Guzzler - Sorry I missed this! We would love your help on this issue.

I'm unsure if the update should include both types of scripts, could @nainar @jpettitt or @choumx clarify?

Yea I think just include the other types of allowed script elements.

Was this page helpful?
0 / 5 - 0 ratings