Amphtml: amp-dynamic-css-classes: Allow for Targeting platforms using extension

Created on 30 Apr 2019  路  3Comments  路  Source: ampproject/amphtml

Was brought up during AMP Conf, and from our CAMP AMP document. 馃憤

Met a partner that was interested in using to target Android vs. iOS. They figured this extension would offer this functionality, and it does not. Neither do any other AMP Extensions.

Their use case was to show different App install banners depending on the device that visited their website. 馃槃

Feature Request
Source
picture torch2424

Most helpful comment

This was debated, but we decided to move away from this to avoid significantly different document variations between platforms. Many extensions (such as app banner) take the platform into account when making their decision and I think this is a better approach because it can get to the source of the solution better that just CSS classes.

picture dvoytenko on 30 Apr 2019
🚀1 🎉1 😄1 👍1

All 3 comments

Assigned to the owners in Owners.yaml. Feel free to re-assign 馃槃

torch2424 picture torch2424 on 30 Apr 2019

This was debated, but we decided to move away from this to avoid significantly different document variations between platforms. Many extensions (such as app banner) take the platform into account when making their decision and I think this is a better approach because it can get to the source of the solution better that just CSS classes.

dvoytenko picture dvoytenko on 30 Apr 2019
🚀1 🎉1 😄1 👍1

I'll close this for now, but please feel free to refile an issue with a more specific use case.

dvoytenko picture dvoytenko on 30 Apr 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

aghassemi picture aghassemi  路  3Comments
aghassemi picture aghassemi  路  3Comments
radiovisual picture radiovisual  路  3Comments
devanes picture devanes  路  3Comments
aghassemi picture aghassemi  路  3Comments