Amphtml: AMP Inabox BTF tests fails on Safari if ran on Saucelabs with the full test suite
The tests added by #20972, which should have fixed it.
Example run: https://travis-ci.org/ampproject/amphtml/jobs/503126033
Local Safari test passing:
zombifier
All 5 comments
Additional context: When run by themselves on SauceLabs they pass:
zombifier
on 25 Apr 2019
@zombifier
- This test ~occasionally~ frequently times out on Chrome too:
- And for single-pass builds:
rsimha
on 26 Apr 2019
@zombifier we recently fixed a couple of issues (#23519 #23512 #23543) that might have caused those flakiness. I also added some extra request-bank error message to ease the debugging.
That said there is a good chance that those tests are easier to deal with now. There are 4 remaining tests need to be unskipped. Would you take another look?
lannka
on 29 Jul 2019
Made #23605 to try reenabling the test and see what happens, but they weirdly enough still fail on Travis. Local testing with Firefox and Chrome works fine.
zombifier
on 5 Aug 2019
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
![stale[bot] picture](https://avatars.githubusercontent.com/in/1724?v=4&s=40)
stale[bot]
on 27 Jan 2021
Related issues
devanes
路
3Comments
edhollinghurst
路
3Comments
samanthamorco
路
3Comments
cvializ
路
3Comments
jpettitt
路
3Comments
Most helpful comment
@zombifier we recently fixed a couple of issues (#23519 #23512 #23543) that might have caused those flakiness. I also added some extra request-bank error message to ease the debugging.
That said there is a good chance that those tests are easier to deal with now. There are 4 remaining tests need to be unskipped. Would you take another look?