Amphtml: AMP-STORY : Page ID change freezes the story totally!

Created on 22 Nov 2018  路  5Comments  路  Source: ampproject/amphtml

What's the issue?

AMP Story saves the last visited page id while visiting the story, if it cannot find the page on reload due to some reasons, then it should start from first page instead of just freezing the whole functionality.

How do we reproduce the issue?

It is a fairly easy issue to reproduce, I wonder how has this been out for such long, To be precise we are facing this issue from the 0.1 version itself.

  1. Make any story with more than 1 page and assign ids to amp-story-page
  2. Visit story in your browser and go to any page other than first one
  3. Go to code and change the id of the page you are on
  4. Reload the story

What browsers are affected?

All browsers that support localStorage.

Which AMP version is affected?

0.1 and 1.0 both

error

Soon Bug stories

All 5 comments

Yep, this makes sense. I'll send a quick fix for 1.0. 0.1 is deprecated and does not get updated with non-critical fixes.

@newmuis Any update on the fix for this?

Sorry, this was complicated by another issue that I believe has since been refactored. I should be able to take another look at this in the coming week.

Sure no problem

Actually, @bramanudom already fixed this with #20238. Thanks @bramanudom!

Was this page helpful?
0 / 5 - 0 ratings