Amphtml: amp-ima-video: Follow up Tracking Issue for New Features

Created on 20 Nov 2018  路  3Comments  路  Source: ampproject/amphtml

relates to #18954

  • [x] show controls on hover (New Feature PR)
  • [x] document the new adLabel in reference docs, as well as state the default
  • [x] Update AMP By Example

@curseagain feel free to take on as many of these as you would like, and feel free to reach out for help on any of them. Or if you can no longer take them on, let me know and I can pick them up 馃槃

monetization
Source
picture torch2424
👍1

Most helpful comment

@curseagain The validator allows any attributes that begin with data-.

picture honeybadgerdontcare on 1 Dec 2018
❤1 👍1

All 3 comments

@torch2424 what about the validator? Do we need to make any changes there to support the addition of the new data-ad-label attribute?

curseagain picture curseagain on 1 Dec 2018

@curseagain The validator allows any attributes that begin with data-.

honeybadgerdontcare picture honeybadgerdontcare on 1 Dec 2018
❤1 👍1

Closing this as everything has been merged in! 馃帀 馃槃

torch2424 picture torch2424 on 10 Jan 2019
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jpettitt picture jpettitt  路  3Comments
sryze picture sryze  路  3Comments
torch2424 picture torch2424  路  3Comments
mrjoro picture mrjoro  路  3Comments
radiovisual picture radiovisual  路  3Comments