Amphtml: Error logs in intersection-observer-polyfill
New error in Canary release, please see go/ampe/CKrhq5ni6tjc6AE
Seems to just be from iOS 12.
Please investigate as P0 and downgrade priority as needed. /cc @zhouyx @torch2424
aghassemi
All 5 comments
Another instance go/ampe/CI7A9JHmssSDkwE but these ones are Chrome and not just iOS.
aghassemi
on 12 Nov 2018
Found the cause. IntersectionObserverApi fail to unobserve and remove mutationObserver event listener after it has been destroyed.
This happens with <amp-iframe> when nested iframe listen to intersection change after unlaid out. Fail to free up resources and cause error logs. But doesn't lead to behavior regression. Set as P1.
to @torch2424
zhouyx
on 12 Nov 2018
Thanks @zhouyx, great investigation.
aghassemi
on 12 Nov 2018
Thank you @aghassemi and @zhouyx For looking into to this and finding the cause! Will get on this ASAP
torch2424
on 12 Nov 2018
馃帀 Thank you @torch2424 for the quick fix! Manually verified the error logs were gone after the fix.
zhouyx
on 21 Nov 2018
Related issues
aghassemi
路
3Comments
Download
路
3Comments
mkhatib
路
3Comments
sryze
路
3Comments
devanes
路
3Comments
Most helpful comment
Found the cause. IntersectionObserverApi fail to unobserve and remove mutationObserver event listener after it has been destroyed.
This happens with
<amp-iframe>when nested iframe listen to intersection change after unlaid out. Fail to free up resources and cause error logs. But doesn't lead to behavior regression. Set as P1.to @torch2424