Amphtml: Upgrade Closure Compiler to current
Having just gone through this, I'm happy to work with whomever wants to pick this up to share knowledge. Don't really mind doing this myself either.
@rsimha @alabiaga Any interest?
choumx
All 9 comments
Happy to work on this.
rsimha
on 15 Oct 2018
We can also split it up. 馃槃 There's about a year of updates left.
CC releases ~monthly. I'd recommend making each upgrade PR as small as possible to minimize risk.
choumx
on 15 Oct 2018
@choumx Was there a sweet spot you managed to identify when you initially attempted an upgrade to the latest version?
rsimha
on 15 Oct 2018
I'd try the smallest upgrade possible first. https://github.com/google/closure-compiler/wiki/Binary-Downloads
choumx
on 15 Oct 2018
This issue hasn't been updated in awhile. @rsimha Do you have any updates?
ampprojectbot
on 24 Jan 2019
21618 has brought us to 20190301. There are still some outstanding fixes that we are awaiting in the next release. I'll close this issue once we adopt it.
rsimha
on 10 Apr 2019
We're currently at the latest version of closure. Closing this in favor of #22452, which tracks the effort to dynamically generate runner.jar, so we can always be at the latest version.
rsimha
on 31 May 2019
This is now truly done, and future updates should be automatic (modulo breaking changes). See https://github.com/ampproject/amphtml/pull/23759#issuecomment-520162085
rsimha
on 11 Aug 2019
One more success in the series: #24096
rsimha
on 22 Aug 2019
Related issues
Download
路
3Comments
cvializ
路
3Comments
mkhatib
路
3Comments
devanes
路
3Comments
akshaylive
路
3Comments