Amphtml: FR: Facebook "page reviews" and "events" components

Created on 30 Sep 2018  Â·  9Comments  Â·  Source: ampproject/amphtml

Should work like ie. "amp-facebook" component.

All New Feature amp-facebook Developer Stale DevX Feature Request components

Most helpful comment

@aghassemi thanks. Alright, I plan to start next week.

All 9 comments

/to @ericlindley-g

Thanks for filing this, @tmdoit — do you currently have pages where you'd like to use this feature?

Currently not, working on projects where I want to use those features.

Got it — thanks @tmdoit

/cc @aghassemi Would this make a good GFI?

It bit more involved than a GFI but certainly doable.

Would be very similar to this Pull Request: https://github.com/ampproject/amphtml/pull/13261 which can be used as reference.

@tmdoit If you are interested in contributing this component, we have great resources to get you started:

https://bit.ly/helpamp

and series of talks in our recent AMP Contributor Summit, particularly https://www.youtube.com/watch?v=kjn322ELFvs and https://www.youtube.com/watch?v=hnJeUzbCt6I

and as mentioned above: #13261 can be used a reference.

I'll be happy to provide real-time help on Slack as needed as well.

@aghassemi thanks. Alright, I plan to start next week.

Thanks @tmdoit! . My Slack handle is the same, ping me anytime here or on Slack i you have questions or run into any issues.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings