Amphtml: Fix JsDoc related lint warnings - round 1

Created on 15 May 2018  路  7Comments  路  Source: ampproject/amphtml

Let's fix the following for round 1:

  • [x] cid*.js
  • [x] 3p/
  • [x] extensions/amp-ad/
  • [x] extensions/amp-analytics/
  • [x] extensions/amp-story-auto-ads/
  • [x] extensions/amp-sticky-ad/

Tip to run lint on selected files:

gulp lint --files=a.js,b.js,c.js

Please reply to this thread if you start work on any of them.

Soon Bug analytics monetization
Source
picture lannka
👍1

Most helpful comment

I'm taking care of the cid*.js now.

picture lannka on 15 May 2018
🎉2

All 7 comments

I'm taking care of the cid*.js now.

lannka picture lannka on 15 May 2018
🎉2

I'm taking amp-analytics.

lannka picture lannka on 24 May 2018

I'll take the amp-ad

zhouyx picture zhouyx on 24 May 2018

amp-story-auto-ads will be fixed with my incoming PR today

calebcordry picture calebcordry on 24 May 2018

taking 3p/

lannka picture lannka on 24 May 2018

@calebcordry Can we close this?

zhouyx picture zhouyx on 15 Jun 2018

Yep, sorry I forgot about this.

calebcordry picture calebcordry on 15 Jun 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Download picture Download  路  3Comments
gmajoulet picture gmajoulet  路  3Comments
mkhatib picture mkhatib  路  3Comments
devanes picture devanes  路  3Comments
radiovisual picture radiovisual  路  3Comments