Amphtml: Always overwrite target attribute for amp-story-cta-layer a to _top

[newmuis]

Any <a> tags descending from <amp-story-cta-layer> should have their target attribute set/rewritten to _topin the AmpStoryCtaLayer buildCallback().

[calebcordry]

So, we are currently using _blank in ads until we work out pageHistoryStack stuff. 🤔

[Enriqe]

What do you think @newmuis ? Should we still use _top?

[calebcordry]

Whats the timeline for this? I will be working on the page history stuff this sprint, so it might be a non-issue.

Race condition? 😎

Edit: it should also be straight forward to temporarily whitelist the ad anchor tag if you are planning on starting this today.

[newmuis]

+1, we should definitely still use _top, but it's fine to just wait until the history stuff gets in so that we don't need to do any extra work.

[newmuis]

We may not need to use _top specifically here, but what I mean is that outlinks should definitely override this property to have a consistent experience. Still determining whether _top or _blank might be better.

[jonsherrard]

Hello @newmuis!

Could this possibly be configurable, I can already think of use cases where I'd want both?

I can understand why you'd not want to use _self or _parent, but I think a choice between _top or _blank would be really helpful in userland.

Thanks for all your work on this project by the way - really love stories as a format.

Ciao for now!

x

[newmuis]

We'd like (at least initially) to ensure a consistent user experience across pages and across stories. It is something that may be able to be relaxed over time, if we're careful about how we do it.

@jonsherrard can you explain your use cases a bit to give a better understanding of how you would use this?

[newmuis]

14275 fixes the history issue mentioned above, so we can start work on this now, to be merged after #14275 is merged.