Amphtml: Disable sync-xhr in amp-iframe/amp-ad

Created on 2 Mar 2018  路  8Comments  路  Source: ampproject/amphtml

What's the issue?

Chrome 65+ allows synchronous XHR to be disabled. Blocking the UI thread on the network is a perf anti-pattern and so should probably not be allowed in AMP documents or embeds.

How do we reproduce the issue?

  1. Create an amp page with an amp-iframe to a site doing a sync-xhr
  2. View in the top stories carousel
  3. Observe jank if you try to swipe when the sync-XHR occurs (especially on a slow network - use throttling in devtools to emulate).

What browsers are affected?

Chrome for now, but at TPAC all other browsers indicated a desire to add this feature as a first step of trying to phase-out sync-xhr.

Which AMP version is affected?

All

/cc @clelland @cramforce with whom this has been discussed offline.

Feature Request monetization

Most helpful comment

Shipped yesterday 馃帀

All 8 comments

I think we should launch this for amp-ad and amp-iframe.

@lannka Could you take this on?

to @jastiv for prioritization.

Given current commitments, it looks like we'll tackle this in the second half of April.
CC @zhouyx

I'll try to implement on my flight back from Australia. I'll implement behind an experiment and then we can see how we can ship it.

@cramforce did you have a chance to look at this? If not, we can probably reassign to someone on the ads team.

Turned this on in canary 5 minutes ago in #16524

Implementation in #14481

Shipping this with our next prod release. Let's see how it goes :)

Shipped yesterday 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

radiovisual picture radiovisual  路  3Comments

aghassemi picture aghassemi  路  3Comments

edhollinghurst picture edhollinghurst  路  3Comments

choumx picture choumx  路  3Comments

jpettitt picture jpettitt  路  3Comments