Amphtml: Lightbox: make lightbox manager and viewer installations work for more than singleDoc mode

Created on 17 Jan 2018 · 6Comments · Source: ampproject/amphtml

Resolve these two hacks:

    const ampdoc = Services.ampdocServiceFor(win).getAmpDoc();
    manager_ = new LightboxManager(ampdoc);

const ampdoc = Services.ampdocServiceFor(win).getAmpDoc();
  return waitForBodyPromise(/**@type {Document}*/ ampdoc.getRootNode()).then(() => {

PWA When Possible Bug

Source

cathyxz

👍3

Most helpful comment

Oh wow, there's interest! xD
Not presently because nobody has expressed interest in it prior to your comment. It's currently sitting in our backlog TODO list. Do you actually want/need this for anything?

cathyxz on 10 Jul 2018

👍2

All 6 comments

This issue seems to be in Pending Triage for awhile. @cathyxz Please triage this to an appropriate milestone.

ampprojectbot on 5 Jun 2018

👍2

Do we have any update regarding this issue?

juanchaur1 on 9 Jul 2018

cathyxz on 10 Jul 2018

👍2

LOL! Yes! I tried to implement the lightbox in different shadow amp and it wasn't working. Quick search in the issues and found this one 😃!

juanchaur1 on 10 Jul 2018

This should work in the next release for some shadow docs, but there will still be a couple of problems when used with a document loaded from <amp-next-page>.