.max.html and .min.html usage has been deprecated. However we fail to update them everywhere in our documentation and comment
Ref PR: #8559
.max.html in our code base. localhost:8000/examples/***.max.html and rename them to end with .htmlOnce approved, your changes will be merged. β‘β‘β‘Congrats on making your first contribution to the AMP Project!β‘β‘β‘ You'll be able to see it live across the web soon!
Thanks, and we hope to see more contributions from you soon.
If you have questions ask in this issue or on your Pull Request see the How to get help section of the Getting Started guide.
I would like to work on this! @zhouyx
@anantoghosh Great!!! Please consider join the AMP Project on GitHub so we can assign this issue to you π
Let me know if any help is needed!
@zhouyx joined.
Thanks! Assigned the issue to you π
@zhouyx I need a little help.
Trying to commit ads/README.md runs gulp check-links on the file which is failing
https://travis-ci.org/ampproject/amphtml/jobs/245967540
Starting 'check-links'...
[14:39:32] [β] http://rawgit.com/slightlyoff/IntersectionObserver/master/index.html#intersectionobserverentry
[14:39:32] [β] https://github.com/ampproject/amphtml/blob/master/src/3p.js
[14:39:33] [β] https://sub-domain.nytimes.com
[14:39:34] [β] ../CONTRIBUTIONG.md#contributing-code
[14:39:34] ERROR Possible dead link(s) found in ads/README.md (please update, or whitelist in build-system/tasks/ch
eck-links.js).
[14:39:34] ERROR Possible dead link(s) found in this PR. Please update ads/README.md or whitelist in build-system/t
asks/check-links.js
These links are separate and not related to my commit.
Should I leave this file?
I have created a pr fixing the links ads/README.md https://github.com/ampproject/amphtml/pull/10124
@anantoghosh Thanks for fixing our readme bug while working on this GFI !!! π π π
Thanks @anantoghosh ! π π π
Most helpful comment
@anantoghosh Thanks for fixing our readme bug while working on this GFI !!! π π π