Amphtml: Remove all .max usage in doc

Created on 14 Jun 2017  Β·  8Comments  Β·  Source: ampproject/amphtml

Description

.max.html and .min.html usage has been deprecated. However we fail to update them everywhere in our documentation and comment

Ref PR: #8559

The Fix

  • Search for .max.html in our code base.
  • Find deprecated usage of localhost:8000/examples/***.max.html and rename them to end with .html
  • Submit for review!

Once approved, your changes will be merged. ⚑⚑⚑Congrats on making your first contribution to the AMP Project!⚑⚑⚑ You'll be able to see it live across the web soon!

Thanks, and we hope to see more contributions from you soon.

Questions?


If you have questions ask in this issue or on your Pull Request see the How to get help section of the Getting Started guide.

GFI Claimed!

Most helpful comment

@anantoghosh Thanks for fixing our readme bug while working on this GFI !!! πŸ‘ πŸŽ‰ πŸŽ‰

All 8 comments

I would like to work on this! @zhouyx

@anantoghosh Great!!! Please consider join the AMP Project on GitHub so we can assign this issue to you πŸ˜„

Let me know if any help is needed!

@zhouyx joined.

Thanks! Assigned the issue to you πŸ˜„

@zhouyx I need a little help.
Trying to commit ads/README.md runs gulp check-links on the file which is failing
https://travis-ci.org/ampproject/amphtml/jobs/245967540

Starting 'check-links'...
[14:39:32] [βœ–] http://rawgit.com/slightlyoff/IntersectionObserver/master/index.html#intersectionobserverentry
[14:39:32] [βœ–] https://github.com/ampproject/amphtml/blob/master/src/3p.js
[14:39:33] [βœ–] https://sub-domain.nytimes.com
[14:39:34] [βœ–] ../CONTRIBUTIONG.md#contributing-code
[14:39:34] ERROR Possible dead link(s) found in ads/README.md (please update, or whitelist in build-system/tasks/ch
eck-links.js).
[14:39:34] ERROR Possible dead link(s) found in this PR. Please update ads/README.md or whitelist in build-system/t
asks/check-links.js

These links are separate and not related to my commit.
Should I leave this file?

I have created a pr fixing the links ads/README.md https://github.com/ampproject/amphtml/pull/10124

@anantoghosh Thanks for fixing our readme bug while working on this GFI !!! πŸ‘ πŸŽ‰ πŸŽ‰

Thanks @anantoghosh ! πŸŽ‰ πŸŽ‰ πŸŽ‰

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gmajoulet picture gmajoulet  Β·  3Comments

choumx picture choumx  Β·  3Comments

sryze picture sryze  Β·  3Comments

Download picture Download  Β·  3Comments

aghassemi picture aghassemi  Β·  3Comments