Amphtml: Validator reports incorrect error messages for certain invalid <link> elements

Created on 19 Dec 2015  Β·  28Comments  Β·  Source: ampproject/amphtml

A few examples of confusing error messages when AMP's development mode is triggered via #development=1:

<link rel="stylesheet" href="https://fonts.googleapis.com/css?" foo="bar">

Actual: INVALID_ATTR_VALUE rel=stylesheet
Expected: MANDATORY_ATTR_MISSING type

(type="text/css" is missing.)

<link rel="stylesheet" href="http://fonts.googleapis.com/css?" type="text/css">

Actual: INVALID_ATTR_VALUE rel=stylesheet
Expected: INVALID_ATTR_VALUE http=not_whitelisted

(The scheme needs to be https.)

Note that Google Fonts' sample embed code suggests the http scheme, not https.

caching

All 28 comments

I think we should remove the requirement for type="text/css" (but allow it).

@Gregable Can we improve the error message in this case?

Thanks for the specific example. We will improve these error messages.

For the curious:
In both cases, the validator generates several possible errors (for each possible link tagspec it could be matching, there are currently 6), and tries to pick the one most likely to be helpful. It's not doing a great job here because it thinks you are trying to do something different than including a font. I think what it's trying to decide is between these two possible valid options:

<link rel=stylesheet href="https://fonts...">
and
<link rel=amphtml href="http://fonts...">

In both cases, there is one incorrect attribute value. Validation isn't sure which you wanted. Reporting both errors is even more confusing (you'd end up with 6 possible errors, I think).

By the way, that embed code is part of the description of that particularly font. The correct recommended embed code uses https.

I'm reaching out to the Fonts team to fix that description.

I talked to them about it. They prefer HTTP for HTTP sites. I wonder if
increased caching (if everyone uses the same schema) would win over the
cost of TLS. Also with the recent attack against github the danger of
loading via HTTP from centralized infra was shown.
On Dec 20, 2015 12:33 PM, "Jordan M. Adler" [email protected]
wrote:

By the way, that embed code is part of the description of that
particularly font. The correct recommended embed code uses https.

I'm reaching out to the Fonts team to fix that description.

β€”
Reply to this email directly or view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-166151914
.

Why not remove rel=stylesheet from the link? It validates.

@88kbbq, that seems like a validator bug. It's also not clear if all browsers will interpret that URL as a stylesheet in this case.

We no longer require text/css in the stylesheet tag. We also no longer allow a link take with _just_ an href attribute like @88kbbq noticed.

For a link tag of
<link rel="stylesheet" href="http://fonts.googleapis.com/css?" type="text/css">

You will now see an error of:

The attribute 'href' in tag 'link rel=stylesheet for fonts' is set to the invalid value 'http://fonts.googleapis.com/css?'. (see https://github.com/ampproject/amphtml/blob/master/spec/amp-html-format.md#custom-fonts)

Which I think is pretty decent.

However, for a link tag of
<link rel="stylesheet" href="https://fonts.googleapis.com/css?" foo="bar">

You will see an error of:

The attribute 'rel' in tag 'link rel=' is set to the invalid value 'stylesheet'.

We still think you are trying to specify one of many other rel= tags for which the href value is not constrained.

So, much closer, but not solved yet.

Putting in M2β€”let me know if this needs more urgent attention

Ok, so I am jumping on the wagon today, and inserted the AMP markup in my HTML, and now can't get past the first line of the validation fixes....

"https://www.metals4uonline.com/:16:0 The attribute 'href' in tag 'link rel=stylesheet for fonts' is set to the invalid value 'style.css'. (see https://github.com/ampproject/amphtml/blob/master/spec/amp-html-format.md#custom-fonts)"

view-source:https://www.metals4uonline.com/#development=1

I am not using any custom fonts as described on the Github page

Hi @robertbrady, welcome to the wagon!

Your html includes:
<link href="style.css" rel="stylesheet" type="text/css">

The error message needs improvement on our side. The issue is that you generally are not allowed to use external stylesheets, they must be inlined. Specific font providers are the exception.

See https://github.com/ampproject/amphtml/blob/master/spec/amp-html-format.md#author-stylesheets for more information on how to inline custom stylesheets.

Hmm, wouldn't using inline styling go against the strategy of keeping one's
code clean, and caching the stylesheet by the user?

But, then again, we're serving up code (ideally for mobile) so a minimalist
strategy would probably be the goal.

On Wed, Feb 24, 2016 at 2:57 PM, Greg Grothaus [email protected]
wrote:

Hi @robertbrady https://github.com/robertbrady, welcome to the wagon!

Your html includes:

The error message needs improvement on our side. The issue is that you
generally are not allowed to use external stylesheets, they must be
inlined. Specific font providers are the exception.

See
https://github.com/ampproject/amphtml/blob/master/spec/amp-html-format.md#author-stylesheets
for more information on how to inline custom stylesheets.

β€”
Reply to this email directly or view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-188450571
.

The requirement for text/css is no longer present.

The attribute 'href' in tag 'link rel=stylesheet for fonts' is set to the invalid value
error because external stylesheets are not permitted.

Please check this link http://stackoverflow.com/questions/42199925/external-style-sheet-is-not-working-in-amp-pages. I getting amp error for external style sheet.

since were talking about errors... here is one.

i deleted this script out of my amp html page...

now everytime i go to AMP Validator, it still picks up that scripts even though its not there...

How do i fix this?

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 notifications@github.com
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-autotag",asynch:1,
useBlacklistUrl:1};(function(){var sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that scripts even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323423826,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX0r-YkQSquuI1omc-MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc
.

I deleted all the cached and cookies out of my browser (chrome) and I used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" notifications@github.com wrote:

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 notifications@github.com
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-autotag",asynch:1,
useBlacklistUrl:1};(function(){var sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that scripts even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323505528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc
.

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 notifications@github.com
wrote:

I deleted all the cached and cookies out of my browser (chrome) and I used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" notifications@github.com wrote:

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-autotag",asynch:1,
useBlacklistUrl:1};(function(){var sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323521799,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc
.

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 notifications@github.com
wrote:

I deleted all the cached and cookies out of my browser (chrome) and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" notifications@github.com wrote:

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323538707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc
.

What are you using to code with?

WSYWIG Editor? Or hand coding?

On Sat, Aug 19, 2017 at 1:12 PM, raynemirrors21 notifications@github.com
wrote:

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 <
[email protected]>
wrote:

I deleted all the cached and cookies out of my browser (chrome) and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" notifications@github.com
wrote:

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323538707>,
or mute the thread
auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323539023,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX0r6ZLqi38Y3tDRdbn7ADjZitFYFclks5sZyV9gaJpZM4G4tIc
.

Adobe dream weaver 2016
On Aug 19, 2017 2:46 PM, "robertbrady" notifications@github.com wrote:

What are you using to code with?

WSYWIG Editor? Or hand coding?

On Sat, Aug 19, 2017 at 1:12 PM, raynemirrors21 notifications@github.com
wrote:

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 <
[email protected]>
wrote:

I deleted all the cached and cookies out of my browser (chrome) and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" notifications@github.com
wrote:

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that
scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323538707>,
or mute the thread
auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323539023>,
or mute the thread
ADX0r6ZLqi38Y3tDRdbn7ADjZitFYFclks5sZyV9gaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323543945,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdsqNkW5Samld1o6xGgCbhwATigIjbx6ks5sZzuhgaJpZM4G4tIc
.

Do you have a local copy of the entire website files?

Do a sitewide search in all files.

Are you using a templating system? With includes?

On Aug 19, 2017 3:14 PM, "raynemirrors21" notifications@github.com wrote:

Adobe dream weaver 2016
On Aug 19, 2017 2:46 PM, "robertbrady" notifications@github.com wrote:

What are you using to code with?

WSYWIG Editor? Or hand coding?

On Sat, Aug 19, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com
wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 <
[email protected]>
wrote:

I deleted all the cached and cookies out of my browser (chrome)
and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" notifications@github.com
wrote:

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that
scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323538707>,
or mute the thread
auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323539023>,
or mute the thread
ADX0r6ZLqi38Y3tDRdbn7ADjZitFYFclks5sZyV9gaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323543945>,
or mute the thread
AdsqNkW5Samld1o6xGgCbhwATigIjbx6ks5sZzuhgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323545348,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX0rw3z7p-edxCTeWux1v4WWPeRkxdjks5sZ0IdgaJpZM4G4tIc
.

I just have all the html files on my desktop and when I need to edit one, I
just open the file in dream weaver and edit it and save it and then I
upload it to my ftp
On Aug 19, 2017 9:01 PM, "robertbrady" notifications@github.com wrote:

Do you have a local copy of the entire website files?

Do a sitewide search in all files.

Are you using a templating system? With includes?

On Aug 19, 2017 3:14 PM, "raynemirrors21" notifications@github.com
wrote:

Adobe dream weaver 2016
On Aug 19, 2017 2:46 PM, "robertbrady" notifications@github.com wrote:

What are you using to code with?

WSYWIG Editor? Or hand coding?

On Sat, Aug 19, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com
wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 <
[email protected]>
wrote:

I deleted all the cached and cookies out of my browser (chrome)
and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" <[email protected]

wrote:

>

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var
sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that
scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323538707>,
or mute the thread
auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323539023>,
or mute the thread
ADX0r6ZLqi38Y3tDRdbn7ADjZitFYFclks5sZyV9gaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323543945>,
or mute the thread
AdsqNkW5Samld1o6xGgCbhwATigIjbx6ks5sZzuhgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323545348>,
or mute the thread
edxCTeWux1v4WWPeRkxdjks5sZ0IdgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323558407,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdsqNiK0RZj_9E-ohMVHMPGclFQZsavDks5sZ5NigaJpZM4G4tIc
.

I can show you what the html looks like by pasting it here?
On Aug 19, 2017 9:01 PM, "robertbrady" notifications@github.com wrote:

Do you have a local copy of the entire website files?

Do a sitewide search in all files.

Are you using a templating system? With includes?

On Aug 19, 2017 3:14 PM, "raynemirrors21" notifications@github.com
wrote:

Adobe dream weaver 2016
On Aug 19, 2017 2:46 PM, "robertbrady" notifications@github.com wrote:

What are you using to code with?

WSYWIG Editor? Or hand coding?

On Sat, Aug 19, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com
wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 <
[email protected]>
wrote:

I deleted all the cached and cookies out of my browser (chrome)
and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" <[email protected]

wrote:

>

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var
sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that
scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323538707>,
or mute the thread
auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323539023>,
or mute the thread
ADX0r6ZLqi38Y3tDRdbn7ADjZitFYFclks5sZyV9gaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323543945>,
or mute the thread
AdsqNkW5Samld1o6xGgCbhwATigIjbx6ks5sZzuhgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323545348>,
or mute the thread
edxCTeWux1v4WWPeRkxdjks5sZ0IdgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323558407,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdsqNiK0RZj_9E-ohMVHMPGclFQZsavDks5sZ5NigaJpZM4G4tIc
.

If your editing the html directly using the flat file method, then I can
already view the html markup by opening up the SOURCE view in my browser.

If you're comfortable with my logging into your website via ftp, I can take
a looksee.

If so, email the deets to [email protected]

On Aug 20, 2017 8:30 AM, "raynemirrors21" notifications@github.com wrote:

I can show you what the html looks like by pasting it here?

On Aug 19, 2017 9:01 PM, "robertbrady" notifications@github.com wrote:

Do you have a local copy of the entire website files?

Do a sitewide search in all files.

Are you using a templating system? With includes?

On Aug 19, 2017 3:14 PM, "raynemirrors21" notifications@github.com
wrote:

Adobe dream weaver 2016
On Aug 19, 2017 2:46 PM, "robertbrady" notifications@github.com wrote:

What are you using to code with?

WSYWIG Editor? Or hand coding?

On Sat, Aug 19, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com
wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 <
[email protected]>
wrote:

I deleted all the cached and cookies out of my browser (chrome)
and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" <[email protected]

wrote:

>

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var
sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that
scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323538707>,
or mute the thread
auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323539023>,
or mute the thread
ADX0r6ZLqi38Y3tDRdbn7ADjZitFYFclks5sZyV9gaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323543945>,
or mute the thread
AdsqNkW5Samld1o6xGgCbhwATigIjbx6ks5sZzuhgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323545348>,
or mute the thread
edxCTeWux1v4WWPeRkxdjks5sZ0IdgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/ampproject/amphtml/issues/1205#issuecomment-323558407
,
or mute the thread
ohMVHMPGclFQZsavDks5sZ5NigaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323585083,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADX0r9PIz98-kfn9NiREfDbyHvvy4vKUks5saDTngaJpZM4G4tIc
.

I'm not at work today but I'll send it to you tomorrow
On Aug 20, 2017 12:03 PM, "robertbrady" notifications@github.com wrote:

If your editing the html directly using the flat file method, then I can
already view the html markup by opening up the SOURCE view in my browser.

If you're comfortable with my logging into your website via ftp, I can take
a looksee.

If so, email the deets to [email protected]

On Aug 20, 2017 8:30 AM, "raynemirrors21" notifications@github.com
wrote:

I can show you what the html looks like by pasting it here?

On Aug 19, 2017 9:01 PM, "robertbrady" notifications@github.com wrote:

Do you have a local copy of the entire website files?

Do a sitewide search in all files.

Are you using a templating system? With includes?

On Aug 19, 2017 3:14 PM, "raynemirrors21" notifications@github.com
wrote:

Adobe dream weaver 2016
On Aug 19, 2017 2:46 PM, "robertbrady" notifications@github.com
wrote:

What are you using to code with?

WSYWIG Editor? Or hand coding?

On Sat, Aug 19, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

https://raynemirrors.com
On Aug 19, 2017 1:06 PM, "robertbrady" notifications@github.com
wrote:

What's your website?

On Sat, Aug 19, 2017 at 8:01 AM, raynemirrors21 <
[email protected]>
wrote:

I deleted all the cached and cookies out of my browser (chrome)
and I
used
IE just to check...
On Aug 19, 2017 1:57 AM, "robertbrady" <
[email protected]

wrote:

>

Maybe you're viewing a cached page?

On Fri, Aug 18, 2017 at 1:12 PM, raynemirrors21 <
[email protected]>
wrote:

since were talking about errors... here is one.

i deleted this script out of my amp html page... data-cfasync="false">$SA={s:271308,tag_info:"1.0.1-
autotag",asynch:1,
useBlacklistUrl:1};(function(){var
sa=document.createElement("
script");sa.type="text/javascript";sa.async=true;sa.
src=("https:"==document.location.protocol?"https://"+$
SA.s+".sa":"http://
"+$SA.s+".a")+".siteapps.com/"+$SA.s+".js";var t=document.
getElementsByTagName("script")
[0];t.parentNode.insertBefore(
sa,t);})();

now everytime i go to AMP Validator, it still picks up that
scripts
even
though its not there...

How do i fix this?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323423826>,
or mute the thread
auth/ADX0r-YkQSquuI1omc-
MZMqAgpDoWxcaks5sZdQcgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323505528>,
or mute the thread
AdsqNrMGRSaO7d1MBV44DfBlEHcgY76Yks5sZodwgaJpZM4G4tIc>
.

>

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323521799>,
or mute the thread
ADX0ry4L3CCqPiRh0poGAAVnqOp0IQaDks5sZtyegaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323538707>,
or mute the thread
auth/AdsqNqxMMNdX6jchWONDBJq-KcG8pkkcks5sZyQRgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323539023>,
or mute the thread
ADX0r6ZLqi38Y3tDRdbn7ADjZitFYFclks5sZyV9gaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
1205#issuecomment-323543945>,
or mute the thread
AdsqNkW5Samld1o6xGgCbhwATigIjbx6ks5sZzuhgaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
1205#issuecomment-323545348>,
or mute the thread
edxCTeWux1v4WWPeRkxdjks5sZ0IdgaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/ampproject/amphtml/issues/
1205#issuecomment-323558407
,
or mute the thread
ohMVHMPGclFQZsavDks5sZ5NigaJpZM4G4tIc>
.

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/ampproject/amphtml/issues/1205#issuecomment-323585083

,
or mute the thread
kfn9NiREfDbyHvvy4vKUks5saDTngaJpZM4G4tIc>
.

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/amphtml/issues/1205#issuecomment-323597829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdsqNuZbqrpAeK8tox_tCk9R0tWzJMwhks5saGbPgaJpZM4G4tIc
.

@Gregable Sorry to dredge up an old post, but

<link href="style.css" rel="stylesheet" type="text/css">
_"The error message needs improvement on our side. The issue is that you generally are not allowed to use external stylesheets, they must be inlined. Specific font providers are the exception."_

Why does the error not say:

_"External stylesheets not permitted or the attribute 'href' in tag 'link rel=stylesheet for fonts' is set to the invalid value"_

Instead of what is nonsensical for many use-cases:

_"The attribute 'href' in tag 'link rel=stylesheet for fonts' is set to the invalid value"_?

Was this page helpful?
0 / 5 - 0 ratings