Amber: [Proposal][CLI] Use complete database name for PostgreSQL

Created on 20 Jun 2018  路  3Comments  路  Source: amberframework/amber

I would like to recommend using complete database name when specifying the PostgreSQL database option:

replace

  -d, --database  # Preconfigure for selected database. Options: pg | mysql | sqlite
                  (default: pg)

with

  -d, --database  # Preconfigure for selected database. Options: postgresql | mysql | sqlite
                  (default: postgresql)
question discussion

Most helpful comment

@drujensen The reason why I mentioned this was because pg refers to Proctor & Gamble and their site is us.pg.com. The site for PostgreSQL is https://www.postgresql.org. Thus, it's very easy to refer to the projects site from both mysql and sqlite by just adding .org to the name. In short, I believe that it makes the name less ambiguous within the CLI especially for new users coming to Amber and I agree that (default: postgresql or pg ) would be a better option.

All 3 comments

@conradwt maybe we can support both? alias the postgresql to pg or vise versa.

@drujensen The reason why I mentioned this was because pg refers to Proctor & Gamble and their site is us.pg.com. The site for PostgreSQL is https://www.postgresql.org. Thus, it's very easy to refer to the projects site from both mysql and sqlite by just adding .org to the name. In short, I believe that it makes the name less ambiguous within the CLI especially for new users coming to Amber and I agree that (default: postgresql or pg ) would be a better option.

@conradwt The driver we are using is called pg (require "pg")so I think its appropriate to keep this consistent. If someone creates a different postgresql driver, we can consider using its name instead.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

olegsobchuk picture olegsobchuk  路  5Comments

eliasjpr picture eliasjpr  路  6Comments

netwarp picture netwarp  路  6Comments

faustinoaq picture faustinoaq  路  4Comments

Meldanor picture Meldanor  路  4Comments