I would like to recommend using complete database name when specifying the PostgreSQL database option:
replace
-d, --database # Preconfigure for selected database. Options: pg | mysql | sqlite
(default: pg)
with
-d, --database # Preconfigure for selected database. Options: postgresql | mysql | sqlite
(default: postgresql)
@conradwt maybe we can support both? alias the postgresql to pg or vise versa.
@drujensen The reason why I mentioned this was because pg refers to Proctor & Gamble and their site is us.pg.com. The site for PostgreSQL is https://www.postgresql.org. Thus, it's very easy to refer to the projects site from both mysql and sqlite by just adding .org to the name. In short, I believe that it makes the name less ambiguous within the CLI especially for new users coming to Amber and I agree that (default: postgresql or pg ) would be a better option.
@conradwt The driver we are using is called pg (require "pg")so I think its appropriate to keep this consistent. If someone creates a different postgresql driver, we can consider using its name instead.
Most helpful comment
@drujensen The reason why I mentioned this was because
pgrefers toProctor & Gambleand their site isus.pg.com. The site forPostgreSQLishttps://www.postgresql.org. Thus, it's very easy to refer to the projects site from bothmysqlandsqliteby just adding.orgto the name. In short, I believe that it makes the name less ambiguous within the CLI especially for new users coming toAmberand I agree that(default: postgresql or pg )would be a better option.