Amber: params parser error

[jaysneg]

Description

params did not parse multi query params

?brand[]=adidas&brand[]=dc

Steps to Reproduce

create form
with elements

input name="brand[]" type="checkbox" value="1"
input name="brand[]" type="checkbox" value="2"

Expected behavior: params[:brand] will be array

Actual behavior: params[:brand] did not exist. params["brand[]"] present

Reproduces how often: always

Versions

0.7.2

[faustinoaq]

@eliasjpr @amberframework/contributors Was this solved on last param refactoring? :sweat_smile:

[jaysneg]

request.query_params

it returns HTTP::Params(@raw_params={"brand[]" => ["2xist", "2xu", "31-phillip-lim"]})

[jaysneg]

How to get {"brand[]" => ["2xist", "2xu", "31-phillip-lim"]} ?

[jaysneg]

I found params.raw_params.fetch_all("brand[]")

[faustinoaq]

request.query_params.to_h # => {"brand[]" => ["2xist", "2xu", "31-phillip-lim"]}

BTW, Can you ask this again on StackOverflow ? I think this would be useful for Amber Community :wink:

If so, please use the tags crystal-lang and amber-framework :+1:

[jaysneg]

@faustinoaq

request.query_params.to_h # => {"brand[]" => "2xist"}

this method did not work correctly

it should return {"brand[]" => ["2xist", "2xu", "31-phillip-lim"]}

but it didn't return

[jaysneg]

@faustinoaq i can ask it at StackOverflow but does it make sense if it bug?

[faustinoaq]

i can ask it at StackOverflow but does it make sense if it bug?

I don't think this is a bug, but just design decisions, /cc @eliasjpr

[jaysneg]

@faustnoaq if it’s feature it better to add it to docs.
I spand time to understend how to get hash of arrays of params it is not obviouse that you need use ‘request.raw_params.fetch_all(“brand[]”)’ to get {“brand[]” => [“brand1”, “brand2”, ....]}

[faustinoaq]

@jaysneg Yeah, I think we can add more documentation on Request & Response section :sweat_smile:

We have an Edit on Github button now, so feel free to contribute opening more issues and even PRs :wink:

[jaysneg]

cool