Amazefilemanager: Remove Google Plus integration

[EmmanuelMess]

AFAIK we are using G+ only to show a user's picture, which seems ridiculous given that we are a file manager. I propose removing G+ integration from this app.
Maybe it could be replaced by letting the user change the picture via settings.

[VishalNehra]

It's optional... Permissions are taken dynamically as per new Android guidelines. I don't see any problem with that.

[EmmanuelMess]

But it is deprecated and it's more code to maintain, we don't need this. How many people actually use this?

[VishalNehra]

A lot ! I use it personally (:

[EmmanuelMess]

Why?

[ghost]

Yeah, G+ should be removed. Adding one through settings would give the same results without relying on Google for it.

[VishalNehra]

@Lionirdeadman some people like me are just too lazy to do that. We like to leave that to Google. It also leaves a consistent user experience for user. For eg. he's using Google Play Store/Inbox/ any other Google app then Amaze will also seem a familiar screen for him to browse.

[EmmanuelMess]

Why do you want your picture in a file manager?...

[EmmanuelMess]

Also how do you know that

A lot !

of people use this feature? We don't send telemetry, right?

[VishalNehra]

@EmmanuelMess we don't, but Google Console does show us the telemetry.

These are the details of last 30 days.

[EmmanuelMess]

If you present me with a good reason as to why we need the user's face in a file manager I will close the issue.

[VishalNehra]

Face and cover picture

[EmmanuelMess]

Ok, if you present me with a good reason as to why we need the user's face and cover picture in a file manager I will close the issue.

[ghost]

Also, including G+ in Amaze means we're pushing the users towards their platform and I don't think that's something we should be doing.

[EmmanuelMess]

Also, isn't Google Plus the only thing keeping us from having a common release with f-droid (instead of the play/fdroid divide)?

[EmmanuelMess]

Ok, as per agreement @VishalNehra has until Tuesday 00:00 UTC+5:30 to present code (for G+ integration) that isn't deprecated and works, on build tools v26.
PS: the agreement was reached because users are already using the function.

[EmmanuelMess]

Time has run out...