For AMOLED
dark theme is not enough for this? lol
No, interesting thing here is that AMOLED screens don't use energy to display black pixels. And dark theme is not 'black'.
+1
+1
Dropping the idea. It'll add more complexion to code. It I don't think it's worth the time, when you could use all the dark themes in the world (using CMTE/substratum/layers).
However I will try to make Amaze compatible with those dark themes by using system resources instead of our custom gray color.
The theme management as it is now lends itself to work really well for built in styles but is definitely rough to work with when you add on extra themes.
I put in PR https://github.com/TeamAmaze/AmazeFileManager/pull/864 that handled adding a "Black" theme that really just changes all background colors to solid black instead of the holo dark. Otherwise, it is identical to the dark theme for purposes of contrast and not adding too much technical debt to the app.
I would agree this may not be worth it, but also doesn't actually change the way the app is behaving.
You have two themes, but a third is adding too much code complexity? Custom colors for some interface elements is fine, but custom background color is crossing some line?
Does the dark theme become unusable if the background color is black? That's really all that's needed afaik.
Thanks for submitting a PR Powwow!
Considering PR #864 is merged, we should close this issue.
Most helpful comment
No, interesting thing here is that AMOLED screens don't use energy to display black pixels. And dark theme is not 'black'.