Almanac.httparchive.org: Make header/footer padding consistent

Created on 3 Jul 2020  路  8Comments  路  Source: HTTPArchive/almanac.httparchive.org

On the 2020 landing page, the spacing inconsistency is more obvious because there is so little main body content:

image

The header, body, and footer should all have the same padding. Currently the footer has less padding.

Also ensure that the spacing is consistent on mobile.

development good first issue

All 8 comments

Good spot. While we're looking at this, I'm still not convinced the home page should go as wide as it does, as discussed in #574 - at least for the top part. Leaves a big old empty space in the middle on ultra-wide monitors:

Home page on ultra-wide monitor with big grey section in the middle

@bazzadp what you think about, treating home page hero section changes as separate issue?

Incase if we want to include that change also part of this issue, couple of questions.

  • can you help me understand the expected behavior?
  • do we want to scale font and layout spacings to adapt wide screen sizes?

@rviscomi QQ, I noticed, header and footer visual treatment for internal pages(other than home page) is different, example header content set to max size of 1280, where as footer resizes based on viewport no max set. Should we keep both header and footer content resize behavior consistent?

Footer content alignment looks little odd, especially logo aligned to left and leaving whitespace on the right, then navigation links aligned center. what you think about center aligned logo to be consistent with nav links alignment? below is the screenshot for your reference.

Should we keep both header and footer content resize behavior consistent?

Good catch, yes that sounds like a good idea.

what you think about center aligned logo to be consistent with nav links alignment?

Yeah that looks good. Could you also center the copyright and accessibility statement text?

thanks, all above mentioned changes are pushed into this PR. https://github.com/HTTPArchive/almanac.httparchive.org/pull/951

@bazzadp what you think about, treating home page hero section changes as separate issue?

Incase if we want to include that change also part of this issue, couple of questions.

  • can you help me understand the expected behavior?
  • do we want to scale font and layout spacings to adapt wide screen sizes?

Good idea, will reopen #574

Closed with #951

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AymenLoukil picture AymenLoukil  路  4Comments

MSakamaki picture MSakamaki  路  4Comments

bazzadp picture bazzadp  路  4Comments

MSakamaki picture MSakamaki  路  6Comments

rviscomi picture rviscomi  路  5Comments