Almanac.httparchive.org: Typo in JS featured snippet

Created on 22 Jun 2020  路  3Comments  路  Source: HTTPArchive/almanac.httparchive.org

Small typo fix, good for a first-time contributor!

image

Sites with more 3P code that 1P

should be

Sites with more 3P code than 1P

good first issue translation writing

Most helpful comment

3P code means "Third-party code" (i.e. things like Google Analytics, Ads marketing trackers...etc. that site developer may not have direct control over).
1P code means "First-party code" (i.e. code hosted by this site and so more likely written and under direct control of this site).

I agree the short names are not very obvious (they are not common acronyms for third-party and first-party) and were chosen as it was felt there was probably too little space to put in the full wording.

However quickly editing in dev tools shows that's maybe not the case:

Featured snippet using 3p and 1p

Looks about the same as what's there currently:

Featured snippet using third-party and first-party

So if you could change this at the same time to make this clearer that would be great!

Note it's "third-party" not "thirdparty" or "third party" when used as an adjective (like here). Similarly with "first-party".

Give us a shout if you run into any issues.

All 3 comments

Hi @rviscomi, I would like to fix this issue. I will send the PR later. Anyway, what is the meaning of P in 3P code and 1P code?

3P code means "Third-party code" (i.e. things like Google Analytics, Ads marketing trackers...etc. that site developer may not have direct control over).
1P code means "First-party code" (i.e. code hosted by this site and so more likely written and under direct control of this site).

I agree the short names are not very obvious (they are not common acronyms for third-party and first-party) and were chosen as it was felt there was probably too little space to put in the full wording.

However quickly editing in dev tools shows that's maybe not the case:

Featured snippet using 3p and 1p

Looks about the same as what's there currently:

Featured snippet using third-party and first-party

So if you could change this at the same time to make this clearer that would be great!

Note it's "third-party" not "thirdparty" or "third party" when used as an adjective (like here). Similarly with "first-party".

Give us a shout if you run into any issues.

Thanks @bazzadp. I just send the PR. Please help to review. :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rviscomi picture rviscomi  路  6Comments

ibnesayeed picture ibnesayeed  路  5Comments

rviscomi picture rviscomi  路  6Comments

rviscomi picture rviscomi  路  5Comments

AymenLoukil picture AymenLoukil  路  4Comments