Alertmanager: Rework SilenceForm

[mxinden]

@fabxc and I went over some improvements needed in the SilenceForm before v0.7:

• Style SilenceForm and remove tachyons classes.
• Show an initial matcher example
• Instead of editing an expired silence, the UI should open the "new silence" dialog with the matchers from the old silence instead
• Make form without matchers invalid. If no matchers are specified "Create silence" button should be deactivated.

[stuartnelson3]

I would add that we should have some visual indication that the creator and comment field need to be filled in. Currently, a silence cannot be created without those being filled in (in the UI), but some indication would clarify that.

[w0rm]

@mxinden Editing duration puts the wrong value in the end time field. We should probably keep raw inputs separate from the Result contents.

[w0rm]

@mxinden If you don't mind I can fix this and maybe address the initial validation state.

My idea was to define type alias ValidatedField a = { value: String, validation: Result String a } instead of Result (String, String) (String, a).

[mxinden]

Sounds like a good idea. Thanks, and sorry for introducing the bug.

On 21 May 2017 12:53 p.m., "Andrey Kuzmin" [e-mail] wrote:

@mxinden https://github.com/mxinden If you don't mind I can fix this
and maybe address the initial validation state.

type alias ValidatedField a = { value: String, validation: Result String a
} instead of Result (String, String) (String, a)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/alertmanager/issues/798#issuecomment-302929227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGuKswfvAhnL5oggm5MBnXTyyQCVJxjAks5r8BeSgaJpZM4NcY_P
.

[w0rm]

@mxinden it's fine. I could've probably noticed this earlier! My plan is to complete this early next week, so that I can demo the new UI at work on Friday.

[mxinden]

Updated issue. Most things are fixed by #806 & #827. Only things missing is:

Make form without matchers invalid. If no matchers are specified "Create silence" button should be deactivated.

[w0rm]

@mxinden it is impossible to have a form without matchers now, so this is fixed.