Ale: Highlighting bug: highlights persist after edits

[sloria]

After editing a file and ensuring that all syntax errors have been resolved, a bunch of highlights appear and don't go away.

The problem appears even after trying different colorschemes.

:ALEInfoToClipboard

 Current Filetype: python
Available Linters: ['flake8', 'mypy', 'pylint']
  Enabled Linters: ['flake8', 'mypy', 'pylint']
 Linter Variables:

let g:ale_python_flake8_executable = 'flake8'
let g:ale_python_flake8_options = ''
let g:ale_python_flake8_use_global = 0
let g:ale_python_mypy_executable = 'mypy'
let g:ale_python_mypy_options = ''
let g:ale_python_mypy_use_global = 0
let g:ale_python_pylint_executable = 'pylint'
let g:ale_python_pylint_options = ''
let g:ale_python_pylint_use_global = 0
 Global Variables:

let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%s'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_linter_aliases = {}
let g:ale_linters = {'html': [], 'javascript': ['eslint']}
let g:ale_open_list = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '>>'
let g:ale_sign_offset = 1000000
let g:ale_sign_warning = '--'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_warn_about_trailing_whitespace = 1
  Command History:

(started) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/47/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/48/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/49/humans.py''']
(finished - exit code 1) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/50/humans.py''']
(started) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/51/humans.py''']
(finished - exit code 1) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/52/humans.py''']
(started) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/53/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/54/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/55/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/56/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/57/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/58/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/59/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/60/humans.py''']
(finished - exit code 1) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/61/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/62/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/63/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/64/humans.py''']
(started) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/65/humans.py''']
(finished - exit code 0) ['/usr/local/bin/zsh', '-c', '''flake8'' --stdin-display-name ''/Users/sloria/humans/humans.py'' - < ''/var/folders/kd/9_jv37r94035mc9b94b3f_6c0000gn/T/vBPL37z/66/humans.py''']

[sjava]

has same problem.

[w0rp]

Are you able to produce a small file which reproduces the issue? Also, let me know your flake8 version, as that could be helpful.

[sloria]

I could reproduce by typing the following into a new python file:

foo=42; bar

Then, even after changing the file to

foo = 42

The highlights still persist:

I am using flake8==3.3.0.

[w0rp]

Thank you for that. I was able to reproduce the bug and fix it. ALE wasn't clearing errors for the new error types. Now it clears any highlights which have a name beginning with 'ALE'.

[sloria]

Thanks a lot!